diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #28470 Fix symfony/console (optional) dependency for MonologBridge (mpdude)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix symfony/console (optional) dependency for MonologBridge

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Since 278c26f589, `ConsoleHandler` tries to pass a verbosity level into `Output::write()`.

In order to make this work, the change 749fba54f9 is required which was first released in 2.8.0.

When using MonologBridge ^3.3 with a lower version of symfony/console than 2.8, an `InvalidArgumentException` with the message `Unknown output type given` will be thrown.

Not sure how to add a test for this... 🤷‍♂️

Commits
-------

d6f5d6bccd Fix symfony/console (optional) dependency for MonologBridge
This commit is contained in:
Nicolas Grekas 2018-09-18 14:28:20 +02:00
commit a6a6dc2c1d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Bridge/Monolog/composer.json
View File

@ -27,11 +27,12 @@
"symfony/var-dumper": "~3.3|~4.0"
},
"conflict": {
"symfony/console": "<2.8",
"symfony/http-foundation": "<3.3"
},
"suggest": {
"symfony/http-kernel": "For using the debugging handlers together with the response life cycle of the HTTP kernel.",
"symfony/console": "For the possibility to show log messages in console commands depending on verbosity settings. You need version ~2.3 of the console for it.",
"symfony/console": "For the possibility to show log messages in console commands depending on verbosity settings. You need version ^2.8 of the console for it.",
"symfony/event-dispatcher": "Needed when using log messages in console commands.",
"symfony/var-dumper": "For using the debugging handlers like the console handler or the log server handler."
},