From a8b986e35e15d93ae1d57131077808a2e7267694 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 6 Oct 2020 18:40:22 +0200 Subject: [PATCH] [VarDumper] fix truncating big arrays --- src/Symfony/Component/VarDumper/Cloner/VarCloner.php | 2 +- .../Component/VarDumper/Tests/Cloner/VarClonerTest.php | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php index a0e2f3824f..8c4221220e 100644 --- a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php +++ b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php @@ -247,7 +247,7 @@ class VarCloner extends AbstractCloner $stub->position = $len++; } elseif ($pos < $maxItems) { if ($maxItems < $pos += \count($a)) { - $a = \array_slice($a, 0, $maxItems - $pos); + $a = \array_slice($a, 0, $maxItems - $pos, true); if ($stub->cut >= 0) { $stub->cut += $pos - $maxItems; } diff --git a/src/Symfony/Component/VarDumper/Tests/Cloner/VarClonerTest.php b/src/Symfony/Component/VarDumper/Tests/Cloner/VarClonerTest.php index 2d55a073ef..e37482fca9 100644 --- a/src/Symfony/Component/VarDumper/Tests/Cloner/VarClonerTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Cloner/VarClonerTest.php @@ -162,7 +162,7 @@ EOTXT; 'Level 3 Item 3', ], [ - 'Level 3 Item 4', + 999 => 'Level 3 Item 4', 'Level 3 Item 5', 'Level 3 Item 6', ], @@ -242,7 +242,7 @@ Symfony\Component\VarDumper\Cloner\Data Object [1] => Array ( [0] => 2 - [2] => 7 + [1] => 7 ) [2] => Array @@ -299,7 +299,7 @@ Symfony\Component\VarDumper\Cloner\Data Object [7] => Array ( - [0] => Level 3 Item 4 + [999] => Level 3 Item 4 ) )