From ef6297afdb537c6f04299382ec36ca43a8eb5ed7 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 20:57:15 +0100 Subject: [PATCH 1/6] [BrowserKit] removed unused $name variable in CookieJar::allValues() method. --- src/Symfony/Component/BrowserKit/CookieJar.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/BrowserKit/CookieJar.php b/src/Symfony/Component/BrowserKit/CookieJar.php index a25f761851..0c0da8e124 100644 --- a/src/Symfony/Component/BrowserKit/CookieJar.php +++ b/src/Symfony/Component/BrowserKit/CookieJar.php @@ -149,7 +149,7 @@ class CookieJar continue; } - foreach ($namedCookies as $name => $cookie) { + foreach ($namedCookies as $cookie) { if ($cookie->isSecure() && 'https' != $parts['scheme']) { continue; } From a7f857da87faa292a13c252f895b0fbce197977d Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 21:11:12 +0100 Subject: [PATCH 2/6] [Console] removed unused $position parameter in Shell::autocompleter() method. --- src/Symfony/Component/Console/Shell.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Console/Shell.php b/src/Symfony/Component/Console/Shell.php index 77561a68bc..1eaa958184 100644 --- a/src/Symfony/Component/Console/Shell.php +++ b/src/Symfony/Component/Console/Shell.php @@ -107,10 +107,10 @@ EOF; /** * Tries to return autocompletion for the current entered text. * - * @param string $text The last segment of the entered text - * @param integer $position The current position + * @param string $text The last segment of the entered text + * @return Boolean|array A list of guessed strings or true */ - private function autocompleter($text, $position) + private function autocompleter($text) { $info = readline_info(); $text = substr($info['line_buffer'], 0, $info['end']); From 7088d942ce96f0c07bea00821aee7815f1921d01 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 21:31:40 +0100 Subject: [PATCH 3/6] [DependencyInjection] fixed wrong local variable name in RemoveUnusedDefinitionsPass::process() method. --- .../Compiler/RemoveUnusedDefinitionsPass.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php index f2dad69649..0c7be667a1 100644 --- a/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php +++ b/src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php @@ -56,7 +56,7 @@ class RemoveUnusedDefinitionsPass implements RepeatablePassInterface $sourceIds[] = $node->getId(); if ($node->isAlias()) { - $referencingAlias[] = $node->getValue(); + $referencingAliases[] = $node->getValue(); } } $isReferenced = (count(array_unique($sourceIds)) - count($referencingAliases)) > 0; From 1ad3d8673b9b37a3f62f0c482777b331f599f095 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 21:35:13 +0100 Subject: [PATCH 4/6] [DependencyInjection] removed unused $compiler local variable in RepeatedPass::process() method. --- .../Component/DependencyInjection/Compiler/RepeatedPass.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Symfony/Component/DependencyInjection/Compiler/RepeatedPass.php b/src/Symfony/Component/DependencyInjection/Compiler/RepeatedPass.php index 376201c9e8..d4af4310c1 100644 --- a/src/Symfony/Component/DependencyInjection/Compiler/RepeatedPass.php +++ b/src/Symfony/Component/DependencyInjection/Compiler/RepeatedPass.php @@ -50,7 +50,6 @@ class RepeatedPass implements CompilerPassInterface */ public function process(ContainerBuilder $container) { - $compiler = $container->getCompiler(); $this->repeat = false; foreach ($this->passes as $pass) { $pass->process($container); From defdac6d0d38e496d095aed541149780ca430f76 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 21:39:22 +0100 Subject: [PATCH 5/6] [DependencyInjection] removed unused private property $parameterBag in ResolveParameterPlaceHoldersPass::process() method. --- .../Compiler/ResolveParameterPlaceHoldersPass.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php index 152ae52385..f6e4c85625 100644 --- a/src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php +++ b/src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php @@ -21,8 +21,6 @@ use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException; */ class ResolveParameterPlaceHoldersPass implements CompilerPassInterface { - private $parameterBag; - /** * Processes the ContainerBuilder to resolve parameter placeholders. * From f750e5420ee5527e97a39f5b19dbcb59e9363fe7 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 10 Jan 2012 21:48:12 +0100 Subject: [PATCH 6/6] [HttpKernel] removed unused local $event variable in Stopwatch::stopSection() method. --- src/Symfony/Component/HttpKernel/Debug/Stopwatch.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/HttpKernel/Debug/Stopwatch.php b/src/Symfony/Component/HttpKernel/Debug/Stopwatch.php index ef2ad8d1b6..cf2d10ee43 100644 --- a/src/Symfony/Component/HttpKernel/Debug/Stopwatch.php +++ b/src/Symfony/Component/HttpKernel/Debug/Stopwatch.php @@ -46,7 +46,7 @@ class Stopwatch */ public function stopSection($id) { - $event = $this->stop('section'); + $this->stop('section'); if ($id) { $this->sections[$id] = $this->events;