[Validator] Fix array notation in the PropertyPath::append()

This commit is contained in:
Jakub Zalas 2014-06-07 12:34:21 +02:00 committed by Fabien Potencier
parent 057c2745ef
commit aa6b08df97
2 changed files with 36 additions and 1 deletions

View File

@ -0,0 +1,35 @@
<?php
/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Symfony\Component\Validator\Tests\Util;
use Symfony\Component\Validator\Util\PropertyPath;
class PropertyPathTest extends \PHPUnit_Framework_TestCase
{
/**
* @dataProvider provideAppendPaths
*/
public function testAppend($basePath, $subPath, $expectedPath, $message)
{
$this->assertSame($expectedPath, PropertyPath::append($basePath, $subPath), $message);
}
public function provideAppendPaths()
{
return array(
array('foo', '', 'foo', 'It returns the basePath if subPath is empty'),
array('', 'bar', 'bar', 'It returns the subPath if basePath is empty'),
array('foo', 'bar', 'foo.bar', 'It append the subPath to the basePath'),
array('foo', '[bar]', 'foo[bar]', 'It does not include the dot separator if subPath uses the array notation')
);
}
}

View File

@ -38,7 +38,7 @@ class PropertyPath
public static function append($basePath, $subPath)
{
if ('' !== (string) $subPath) {
if ('[' === $subPath{1}) {
if ('[' === $subPath{0}) {
return $basePath.$subPath;
}