diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33314 [DomCrawler] Fix @throws (dunglas)

Browse Source 
This PR was merged into the 4.3 branch.

Discussion
----------

[DomCrawler] Fix @throws

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

A `LogicException` is thrown, not a `RuntimeException`.

Commits
-------

a414c0323a [DomCrawler] Fix @throws
This commit is contained in:
Fabien Potencier 2019-08-25 09:01:30 +02:00
commit aa81e2721a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/DomCrawler/Crawler.php
View File

@ -1209,7 +1209,7 @@ class Crawler implements \Countable, \IteratorAggregate
}
/**
* @throws \RuntimeException If the CssSelector Component is not available
* @throws \LogicException If the CssSelector Component is not available
*/
private function createCssSelectorConverter(): CssSelectorConverter
{