From 9ba0a9118a9e3088fc32b7fa98736a62d7afe724 Mon Sep 17 00:00:00 2001 From: Yup Date: Mon, 5 Jul 2021 20:03:53 +0300 Subject: [PATCH 1/2] Declare returned type. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes Method getSubscribedEvents() return type has no value type specified in iterable type array. 💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type --- .../Component/EventDispatcher/EventSubscriberInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/EventDispatcher/EventSubscriberInterface.php b/src/Symfony/Component/EventDispatcher/EventSubscriberInterface.php index 741590b1bf..a0fc96dfe2 100644 --- a/src/Symfony/Component/EventDispatcher/EventSubscriberInterface.php +++ b/src/Symfony/Component/EventDispatcher/EventSubscriberInterface.php @@ -43,7 +43,7 @@ interface EventSubscriberInterface * The code must not depend on runtime state as it will only be called at compile time. * All logic depending on runtime state must be put into the individual methods handling the events. * - * @return array The event names to listen to + * @return array The event names to listen to */ public static function getSubscribedEvents(); } From 660037858f784b04656c8ab1d4b13d3b5543286d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maximilian=20B=C3=B6sing?= <2189546+boesing@users.noreply.github.com> Date: Tue, 13 Jul 2021 19:14:44 +0200 Subject: [PATCH 2/2] qa: add missing type-hints to workflow `Transition` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com> --- src/Symfony/Component/Workflow/Transition.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/Symfony/Component/Workflow/Transition.php b/src/Symfony/Component/Workflow/Transition.php index f5a19b1049..b1dbcbe061 100644 --- a/src/Symfony/Component/Workflow/Transition.php +++ b/src/Symfony/Component/Workflow/Transition.php @@ -32,16 +32,25 @@ class Transition $this->tos = (array) $tos; } + /** + * @return string + */ public function getName() { return $this->name; } + /** + * @return string[] + */ public function getFroms() { return $this->froms; } + /** + * @return string[] + */ public function getTos() { return $this->tos;