bug #35193 [TwigBridge] button_widget now has its title attr translated even if its label = null or false (stephen-lewis)
This PR was squashed before being merged into the 3.4 branch (closes #35193).
Discussion
----------
[TwigBridge] button_widget now has its title attr translated even if its label = null or false
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #34330
| License | MIT
| Doc PR | TODO
Duplicate of #34436 but changed to bugfix and applied to 3.4. Buttons with null or false 'label' options will now have their 'title' attribute translated against the current translation domain.
Commits
-------
2a5d9cb75a
[TwigBridge] button_widget now has its title attr translated even if its label = null or false
This commit is contained in:
commit
aaf6915661
@ -222,13 +222,11 @@
|
|||||||
'%name%': name,
|
'%name%': name,
|
||||||
'%id%': id,
|
'%id%': id,
|
||||||
}) %}
|
}) %}
|
||||||
{%- elseif label is same as(false) -%}
|
{%- elseif label is not same as(false) -%}
|
||||||
{% set translation_domain = false %}
|
|
||||||
{%- else -%}
|
|
||||||
{% set label = name|humanize %}
|
{% set label = name|humanize %}
|
||||||
{%- endif -%}
|
{%- endif -%}
|
||||||
{%- endif -%}
|
{%- endif -%}
|
||||||
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}</button>
|
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as(false) or label is same as(false) ? label : label|trans({}, translation_domain) }}</button>
|
||||||
{%- endblock button_widget -%}
|
{%- endblock button_widget -%}
|
||||||
|
|
||||||
{%- block submit_widget -%}
|
{%- block submit_widget -%}
|
||||||
|
Reference in New Issue
Block a user