minor #34991 CS for AccessDecisionManager (aschempp)
This PR was merged into the 3.4 branch.
Discussion
----------
CS for AccessDecisionManager
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | #34548
| License | MIT
| Doc PR | -
As discussed in #34548 with @nicolas-grekas here's a CS change for the `AccessDecisionManager`
Commits
-------
b3742ec493
CS
This commit is contained in:
commit
ab8841e248
@ -86,17 +86,13 @@ class AccessDecisionManager implements AccessDecisionManagerInterface
|
||||
$deny = 0;
|
||||
foreach ($this->voters as $voter) {
|
||||
$result = $this->vote($voter, $token, $object, $attributes);
|
||||
switch ($result) {
|
||||
case VoterInterface::ACCESS_GRANTED:
|
||||
return true;
|
||||
|
||||
case VoterInterface::ACCESS_DENIED:
|
||||
++$deny;
|
||||
if (VoterInterface::ACCESS_GRANTED === $result) {
|
||||
return true;
|
||||
}
|
||||
|
||||
break;
|
||||
|
||||
default:
|
||||
break;
|
||||
if (VoterInterface::ACCESS_DENIED === $result) {
|
||||
++$deny;
|
||||
}
|
||||
}
|
||||
|
||||
@ -128,16 +124,10 @@ class AccessDecisionManager implements AccessDecisionManagerInterface
|
||||
foreach ($this->voters as $voter) {
|
||||
$result = $this->vote($voter, $token, $object, $attributes);
|
||||
|
||||
switch ($result) {
|
||||
case VoterInterface::ACCESS_GRANTED:
|
||||
++$grant;
|
||||
|
||||
break;
|
||||
|
||||
case VoterInterface::ACCESS_DENIED:
|
||||
++$deny;
|
||||
|
||||
break;
|
||||
if (VoterInterface::ACCESS_GRANTED === $result) {
|
||||
++$grant;
|
||||
} elseif (VoterInterface::ACCESS_DENIED === $result) {
|
||||
++$deny;
|
||||
}
|
||||
}
|
||||
|
||||
@ -169,17 +159,12 @@ class AccessDecisionManager implements AccessDecisionManagerInterface
|
||||
foreach ($attributes as $attribute) {
|
||||
$result = $this->vote($voter, $token, $object, [$attribute]);
|
||||
|
||||
switch ($result) {
|
||||
case VoterInterface::ACCESS_GRANTED:
|
||||
++$grant;
|
||||
if (VoterInterface::ACCESS_DENIED === $result) {
|
||||
return false;
|
||||
}
|
||||
|
||||
break;
|
||||
|
||||
case VoterInterface::ACCESS_DENIED:
|
||||
return false;
|
||||
|
||||
default:
|
||||
break;
|
||||
if (VoterInterface::ACCESS_GRANTED === $result) {
|
||||
++$grant;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user