diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs #26898

Browse Source 
Remove unnecessary loop
Trim messages on build rather than on display
This commit is contained in:
Pascal Montoya 2018-06-18 12:27:25 +02:00
parent da42b3e23c
commit acfb325a35
No known key found for this signature in database
GPG Key ID: 6C8C858C247C9140
1 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Symfony/Bridge/Twig/Command/DebugCommand.php
View File

@ -89,16 +89,7 @@ EOF
$data['tests'] = array_keys($data['tests']);
$data['loader_paths'] = $this->getLoaderPaths();
if ($wrongBundles = $this->findWrongBundleOverrides()) {
$messages = $this->buildWarningMessages($wrongBundles);
$data['warnings'] = array_reduce(
$messages,
function ($carry, $message) {
$carry[] = $message;
return $carry;
},
array()
);
$data['warnings'] = $this->buildWarningMessages($wrongBundles);
}
$io->writeln(json_encode($data));
@ -143,12 +134,9 @@ EOF
$io->section('Loader Paths');
$io->table(array('Namespace', 'Paths'), $rows);
$messages = $this->buildWarningMessages($this->findWrongBundleOverrides());
array_walk(
$messages,
function ($message) use ($io) {
$io->warning(trim($message));
}
);
foreach ($messages as $message) {
$io->warning($message);
}
return 0;
}
@ -344,7 +332,7 @@ EOF
}
}
}
$messages[] = $message;
$messages[] = trim($message);
}
return $messages;