bug #31344 [FrameworkBundle] Remove SendFailedMessageToFailureTransportListener if no failure transport (chalasr)
This PR was merged into the 4.3-dev branch.
Discussion
----------
[FrameworkBundle] Remove SendFailedMessageToFailureTransportListener if no failure transport
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | n/a
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
When there is no failure transport configured and `messenger:consume` hits a failing message:
> Argument 2 passed to Symfony\Component\Messenger\EventListener\SendFailedMessageToFailureTransportListener::__construct() must be of the type string, null given
/cc @weaverryan
Commits
-------
bdf4e913be
[FrameworkBundle] Remove SendFailedMessageToFailureTransportListener definition if no failure transport
This commit is contained in:
commit
ad6e888a6f
@ -1774,10 +1774,9 @@ class FrameworkExtension extends Extension
|
||||
$container->getDefinition('messenger.retry_strategy_locator')
|
||||
->replaceArgument(0, $transportRetryReferences);
|
||||
|
||||
if ($config['failure_transport']) {
|
||||
$container->getDefinition('messenger.failure.send_failed_message_to_failure_transport_listener')
|
||||
->replaceArgument(1, $config['failure_transport']);
|
||||
|
||||
if ($config['failure_transport']) {
|
||||
$container->getDefinition('console.command.messenger_failed_messages_retry')
|
||||
->replaceArgument(0, $config['failure_transport'])
|
||||
->replaceArgument(4, $transportRetryReferences[$config['failure_transport']] ?? null);
|
||||
@ -1786,6 +1785,7 @@ class FrameworkExtension extends Extension
|
||||
$container->getDefinition('console.command.messenger_failed_messages_remove')
|
||||
->replaceArgument(0, $config['failure_transport']);
|
||||
} else {
|
||||
$container->removeDefinition('messenger.failure.send_failed_message_to_failure_transport_listener');
|
||||
$container->removeDefinition('console.command.messenger_failed_messages_retry');
|
||||
$container->removeDefinition('console.command.messenger_failed_messages_show');
|
||||
$container->removeDefinition('console.command.messenger_failed_messages_remove');
|
||||
|
Reference in New Issue
Block a user