diff --git a/src/Symfony/Bundle/AsseticBundle/Command/DumpCommand.php b/src/Symfony/Bundle/AsseticBundle/Command/DumpCommand.php index 98d3bc28de..8c22e38b64 100644 --- a/src/Symfony/Bundle/AsseticBundle/Command/DumpCommand.php +++ b/src/Symfony/Bundle/AsseticBundle/Command/DumpCommand.php @@ -171,7 +171,7 @@ class DumpCommand extends Command */ private function doDump(AssetInterface $asset, OutputInterface $output) { - $target = rtrim($this->basePath, '/').'/'.str_replace('_controller/', '', $asset->getTargetUrl()); + $target = rtrim($this->basePath, '/').'/'.str_replace('_controller/', '', $asset->getTargetPath()); if (!is_dir($dir = dirname($target))) { $output->writeln('[dir+] '.$dir); if (false === @mkdir($dir, 0777, true)) { diff --git a/src/Symfony/Bundle/AsseticBundle/Factory/AssetFactory.php b/src/Symfony/Bundle/AsseticBundle/Factory/AssetFactory.php index 70a55b80e5..02dd1c493f 100644 --- a/src/Symfony/Bundle/AsseticBundle/Factory/AssetFactory.php +++ b/src/Symfony/Bundle/AsseticBundle/Factory/AssetFactory.php @@ -47,7 +47,7 @@ class AssetFactory extends BaseAssetFactory * Please note this is a naive implementation of globs in that it doesn't * attempt to support bundle inheritance within the glob pattern itself. */ - protected function parseInput($input) + protected function parseInput($input, array $options = array()) { // expand bundle notation if ('@' == $input[0] && false !== strpos($input, '/')) { @@ -60,7 +60,7 @@ class AssetFactory extends BaseAssetFactory } } - return parent::parseInput($input); + return parent::parseInput($input, $options); } protected function createAssetReference($name) diff --git a/src/Symfony/Bundle/AsseticBundle/Factory/Worker/UseControllerWorker.php b/src/Symfony/Bundle/AsseticBundle/Factory/Worker/UseControllerWorker.php index 527c81d706..b8941543d3 100644 --- a/src/Symfony/Bundle/AsseticBundle/Factory/Worker/UseControllerWorker.php +++ b/src/Symfony/Bundle/AsseticBundle/Factory/Worker/UseControllerWorker.php @@ -23,9 +23,9 @@ class UseControllerWorker implements WorkerInterface { public function process(AssetInterface $asset) { - $targetUrl = $asset->getTargetUrl(); + $targetUrl = $asset->getTargetPath(); if ($targetUrl && '/' != $targetUrl[0] && 0 !== strpos($targetUrl, '_controller/')) { - $asset->setTargetUrl('_controller/'.$targetUrl); + $asset->setTargetPath('_controller/'.$targetUrl); } return $asset; diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/compass.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/compass.xml index 59771ef3bf..786e403339 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/compass.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/compass.xml @@ -12,7 +12,6 @@ - %assetic.read_from% %assetic.filter.compass.sass% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/less.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/less.xml index 4f149dad36..a6abf5c021 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/less.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/less.xml @@ -13,7 +13,6 @@ - %assetic.read_from% %assetic.filter.less.node% %assetic.filter.less.node_paths% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/lessphp.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/lessphp.xml index 785d7f45e6..f915557cb1 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/lessphp.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/lessphp.xml @@ -11,7 +11,6 @@ - %assetic.read_from% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sass.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sass.xml index ee866e3d8c..a3d9303974 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sass.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sass.xml @@ -12,7 +12,6 @@ - %assetic.read_from% %assetic.filter.sass.bin% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/scss.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/scss.xml index f581fafe9a..89e2ea23b3 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/scss.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/scss.xml @@ -12,7 +12,6 @@ - %assetic.read_from% %assetic.filter.scss.sass% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sprockets.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sprockets.xml index c67576aba0..6b32426cdd 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sprockets.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/sprockets.xml @@ -12,7 +12,6 @@ - %assetic.read_from% %assetic.filter.sprockets.bin% diff --git a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/stylus.xml b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/stylus.xml index 4e60f7ee1f..166c527493 100644 --- a/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/stylus.xml +++ b/src/Symfony/Bundle/AsseticBundle/Resources/config/filters/stylus.xml @@ -13,7 +13,6 @@ - %assetic.read_from% %assetic.filter.stylus.node% %assetic.filter.stylus.node_paths% diff --git a/src/Symfony/Bundle/AsseticBundle/Routing/AsseticLoader.php b/src/Symfony/Bundle/AsseticBundle/Routing/AsseticLoader.php index d2da68465c..a18e1be7d8 100644 --- a/src/Symfony/Bundle/AsseticBundle/Routing/AsseticLoader.php +++ b/src/Symfony/Bundle/AsseticBundle/Routing/AsseticLoader.php @@ -99,7 +99,7 @@ class AsseticLoader extends Loader ); // remove the fake front controller - $pattern = str_replace('_controller/', '', $asset->getTargetUrl()); + $pattern = str_replace('_controller/', '', $asset->getTargetPath()); if ($format = pathinfo($pattern, PATHINFO_EXTENSION)) { $defaults['_format'] = $format; diff --git a/src/Symfony/Bundle/AsseticBundle/Templating/StaticAsseticHelper.php b/src/Symfony/Bundle/AsseticBundle/Templating/StaticAsseticHelper.php index 7827e06976..9fa2011311 100644 --- a/src/Symfony/Bundle/AsseticBundle/Templating/StaticAsseticHelper.php +++ b/src/Symfony/Bundle/AsseticBundle/Templating/StaticAsseticHelper.php @@ -40,6 +40,6 @@ class StaticAsseticHelper extends AsseticHelper protected function getAssetUrl(AssetInterface $asset, $options = array()) { - return $this->assetsHelper->getUrl($asset->getTargetUrl(), isset($options['package']) ? $options['package'] : null); + return $this->assetsHelper->getUrl($asset->getTargetPath(), isset($options['package']) ? $options['package'] : null); } } diff --git a/src/Symfony/Bundle/AsseticBundle/Tests/Command/DumpCommandTest.php b/src/Symfony/Bundle/AsseticBundle/Tests/Command/DumpCommandTest.php index 372d5e10c8..d0f59ed96c 100644 --- a/src/Symfony/Bundle/AsseticBundle/Tests/Command/DumpCommandTest.php +++ b/src/Symfony/Bundle/AsseticBundle/Tests/Command/DumpCommandTest.php @@ -108,7 +108,7 @@ class DumpCommandTest extends \PHPUnit_Framework_TestCase ->method('isDebug') ->will($this->returnValue(false)); $asset->expects($this->once()) - ->method('getTargetUrl') + ->method('getTargetPath') ->will($this->returnValue('test_asset.css')); $asset->expects($this->once()) ->method('dump') @@ -140,7 +140,7 @@ class DumpCommandTest extends \PHPUnit_Framework_TestCase ->method('isDebug') ->will($this->returnValue(true)); $asset->expects($this->once()) - ->method('getTargetUrl') + ->method('getTargetPath') ->will($this->returnValue('test_asset.css')); $asset->expects($this->once()) ->method('dump') @@ -149,7 +149,7 @@ class DumpCommandTest extends \PHPUnit_Framework_TestCase ->method('getIterator') ->will($this->returnValue(new \ArrayIterator(array($leaf)))); $leaf->expects($this->once()) - ->method('getTargetUrl') + ->method('getTargetPath') ->will($this->returnValue('test_leaf.css')); $leaf->expects($this->once()) ->method('dump') diff --git a/src/Symfony/Bundle/AsseticBundle/Tests/Templating/AsseticHelperTest.php b/src/Symfony/Bundle/AsseticBundle/Tests/Templating/AsseticHelperTest.php index 50c82613e8..5c124bba17 100644 --- a/src/Symfony/Bundle/AsseticBundle/Tests/Templating/AsseticHelperTest.php +++ b/src/Symfony/Bundle/AsseticBundle/Tests/Templating/AsseticHelperTest.php @@ -51,6 +51,6 @@ class AsseticHelperForTest extends AsseticHelper { protected function getAssetUrl(AssetInterface $asset, $options = array()) { - return $asset->getTargetUrl(); + return $asset->getTargetPath(); } } diff --git a/src/Symfony/Bundle/AsseticBundle/Twig/AsseticNode.php b/src/Symfony/Bundle/AsseticBundle/Twig/AsseticNode.php index 1202b4abe0..10b7eee79c 100644 --- a/src/Symfony/Bundle/AsseticBundle/Twig/AsseticNode.php +++ b/src/Symfony/Bundle/AsseticBundle/Twig/AsseticNode.php @@ -27,7 +27,7 @@ class AsseticNode extends BaseAsseticNode ->raw('isset($context[\'assetic\'][\'use_controller\']) && $context[\'assetic\'][\'use_controller\'] ? ') ->subcompile($this->getPathFunction($name)) ->raw(' : ') - ->subcompile($this->getAssetFunction($asset->getTargetUrl())) + ->subcompile($this->getAssetFunction($asset->getTargetPath())) ; }