diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PropertyInfo] Prevent returning int values in some cases.

Browse Source
This commit is contained in:
Kévin Dunglas 2017-04-13 21:00:55 +02:00
parent d564c6ad7d
commit b190ec241e
No known key found for this signature in database
GPG Key ID: 4D04EBEF06AAF3A6
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
View File

@ -64,7 +64,7 @@ class ReflectionExtractor implements PropertyListExtractorInterface, PropertyTyp
$properties = array(); $properties = array();
foreach ($reflectionClass->getProperties(\ReflectionProperty::IS_PUBLIC) as $reflectionProperty) { foreach ($reflectionClass->getProperties(\ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
$properties[$reflectionProperty->name] = true; $properties[$reflectionProperty->name] = $reflectionProperty->name;
} }
foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) { foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
@ -79,10 +79,10 @@ class ReflectionExtractor implements PropertyListExtractorInterface, PropertyTyp
if (!$reflectionClass->hasProperty($propertyName) && !preg_match('/^[A-Z]{2,}/', $propertyName)) { if (!$reflectionClass->hasProperty($propertyName) && !preg_match('/^[A-Z]{2,}/', $propertyName)) {
$propertyName = lcfirst($propertyName); $propertyName = lcfirst($propertyName);
} }
$properties[$propertyName] = true; $properties[$propertyName] = $propertyName;
} }
return array_keys($properties); return array_values($properties);
} }
/** /**

3
src/Symfony/Component/PropertyInfo/Tests/Extractors/ReflectionExtractorTest.php
View File

@ -32,7 +32,7 @@ class ReflectionExtractorTest extends TestCase
public function testGetProperties() public function testGetProperties()
{ {
$this->assertEquals( $this->assertSame(
array( array(
'bal', 'bal',
'parent', 'parent',
@ -49,6 +49,7 @@ class ReflectionExtractorTest extends TestCase
'a', 'a',
'DOB', 'DOB',
'Id', 'Id',
'123',
'c', 'c',
'd', 'd',
'e', 'e',

4
src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php
View File

@ -116,4 +116,8 @@ class Dummy extends ParentDummy
public function getId() public function getId()
{ {
} }
public function get123()
{
}
} }