diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #17748 [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler (jakzal)

Browse Source 
This PR was merged into the 2.8 branch.

Discussion
----------

[DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16421
| License       | MIT
| Doc PR        | -

Overriding the `SplObjectStorage::getHash()` is affected by a [PHP bug](https://bugs.php.net/bug.php?id=67582), which makes the Crawler unusable in Symfony 2.8 for anyone who relied on `SplObjectStorage` methods.

Removing the `getHash()` method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and other `SplObjectStorage` methods will trigger the error, it is the simplest thing we can do to maintain BC.

Commits
-------

3d7f6c6 [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler
This commit is contained in:
Jakub Zalas 2016-02-10 15:16:32 +00:00
commit b1e5149ec9
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Symfony/Component/DomCrawler/Crawler.php
View File

@ -950,16 +950,6 @@ class Crawler extends \SplObjectStorage
return parent::offsetGet($object);
}
/**
* @deprecated Using the SplObjectStorage API on the Crawler is deprecated as of 2.8 and will be removed in 3.0.
*/
public function getHash($object)
{
$this->triggerDeprecation(__METHOD__, true);
return parent::getHash($object);
}
/**
* Filters the list of nodes with an XPath expression.
*