diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #26183 [DI] Add null check for removeChild (changmin.keum) 

This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #26183).

Discussion
----------

[DI] Add null check for removeChild

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I'm using Symfony 2.8 and PHP Fatal error occurs very rarely when I do assetic:dump / cache:warmup as below.(also on Symfony 2.7)

`
PHP Fatal error:  Call to a member function removeChild() on null in .../symfony/symfony/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php on line 350
`

It does occur very rarely. Also, after several retries, it works fine.

The xml file which triggers error is as below(both version) and I didn't modify anything.

https://github.com/symfony/swiftmailer-bundle/blob/v2.3.8/Resources/config/swiftmailer.xml
https://github.com/symfony/swiftmailer-bundle/blob/v2.6.7/Resources/config/swiftmailer.xml

Once more, error occurs so randomly. So, I can't be sure in what situation it occurs. But this modification does fix the problem and no side effect.

Commits
-------

a5f05a0486 [DI] Add null check for removeChild
This commit is contained in:
Fabien Potencier 2018-02-15 08:59:01 +01:00
parent 2bccaaa9d1 a5f05a0486
commit b2716837a7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
View File

@ -324,7 +324,9 @@ class XmlFileLoader extends FileLoader
$domElement->parentNode->replaceChild($tmpDomElement, $domElement);
$tmpDomElement->setAttribute('id', $id);
} else {
$domElement->parentNode->removeChild($domElement);
if (null !== $domElement->parentNode) {
$domElement->parentNode->removeChild($domElement);
}
}
}
}