diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Stopwatch] Fixed a bug in stopwatch event getStartTime

Browse Source
This commit is contained in:
Timo Bakx 2019-10-29 20:29:12 +01:00
parent 2ecd7936b1
commit b2b7eab949
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Symfony/Component/Stopwatch/StopwatchEvent.php
View File

@ -154,7 +154,15 @@ class StopwatchEvent
*/ */
public function getStartTime() public function getStartTime()
{ {
return isset($this->periods[0]) ? $this->periods[0]->getStartTime() : 0; if (isset($this->periods[0])) {
return $this->periods[0]->getStartTime();
}
if ($this->started) {
return $this->started[0];
}
return 0;
} }
/** /**

21
src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php
View File

@ -152,6 +152,27 @@ class StopwatchEventTest extends TestCase
$this->assertEqualsWithDelta(0, $event->getStartTime(), self::DELTA); $this->assertEqualsWithDelta(0, $event->getStartTime(), self::DELTA);
} }
public function testStartTimeWhenStartedLater()
{
$event = new StopwatchEvent(microtime(true) * 1000);
usleep(100000);
$this->assertLessThanOrEqual(0.5, $event->getStartTime());
$event = new StopwatchEvent(microtime(true) * 1000);
usleep(100000);
$event->start();
$event->stop();
$this->assertLessThanOrEqual(101, $event->getStartTime());
$event = new StopwatchEvent(microtime(true) * 1000);
usleep(100000);
$event->start();
usleep(100000);
$this->assertEqualsWithDelta(100, $event->getStartTime(), self::DELTA);
$event->stop();
$this->assertEqualsWithDelta(100, $event->getStartTime(), self::DELTA);
}
public function testInvalidOriginThrowsAnException() public function testInvalidOriginThrowsAnException()
{ {
$this->expectException('InvalidArgumentException'); $this->expectException('InvalidArgumentException');