Merge branch '4.4'
* 4.4: [Cache] Disable igbinary on PHP >= 7.4
This commit is contained in:
commit
b30ea0c7a8
@ -25,9 +25,9 @@ class DefaultMarshaller implements MarshallerInterface
|
||||
public function __construct(bool $useIgbinarySerialize = null)
|
||||
{
|
||||
if (null === $useIgbinarySerialize) {
|
||||
$useIgbinarySerialize = \extension_loaded('igbinary') && \PHP_VERSION_ID !== 70400;
|
||||
} elseif ($useIgbinarySerialize && (!\extension_loaded('igbinary') || \PHP_VERSION_ID === 70400)) {
|
||||
throw new CacheException('The "igbinary" PHP extension is not '.(\PHP_VERSION_ID === 70400 ? 'compatible with PHP 7.4.0.' : 'loaded.'));
|
||||
$useIgbinarySerialize = \extension_loaded('igbinary') && \PHP_VERSION_ID < 70400;
|
||||
} elseif ($useIgbinarySerialize && (!\extension_loaded('igbinary') || \PHP_VERSION_ID >= 70400)) {
|
||||
throw new CacheException('The "igbinary" PHP extension is not '.(\PHP_VERSION_ID >= 70400 ? 'compatible with PHP 7.4.' : 'loaded.'));
|
||||
}
|
||||
$this->useIgbinarySerialize = $useIgbinarySerialize;
|
||||
}
|
||||
@ -66,7 +66,7 @@ class DefaultMarshaller implements MarshallerInterface
|
||||
return null;
|
||||
}
|
||||
static $igbinaryNull;
|
||||
if ($value === ($igbinaryNull ?? $igbinaryNull = \extension_loaded('igbinary') && \PHP_VERSION_ID !== 70400 ? igbinary_serialize(null) : false)) {
|
||||
if ($value === ($igbinaryNull ?? $igbinaryNull = \extension_loaded('igbinary') && \PHP_VERSION_ID < 70400 ? igbinary_serialize(null) : false)) {
|
||||
return null;
|
||||
}
|
||||
$unserializeCallbackHandler = ini_set('unserialize_callback_func', __CLASS__.'::handleUnserializeCallback');
|
||||
|
@ -24,7 +24,7 @@ class DefaultMarshallerTest extends TestCase
|
||||
'b' => function () {},
|
||||
];
|
||||
|
||||
$expected = ['a' => \extension_loaded('igbinary') && \PHP_VERSION_ID !== 70400 ? igbinary_serialize(123) : serialize(123)];
|
||||
$expected = ['a' => \extension_loaded('igbinary') && \PHP_VERSION_ID < 70400 ? igbinary_serialize(123) : serialize(123)];
|
||||
$this->assertSame($expected, $marshaller->marshall($values, $failed));
|
||||
$this->assertSame(['b'], $failed);
|
||||
}
|
||||
@ -43,8 +43,8 @@ class DefaultMarshallerTest extends TestCase
|
||||
*/
|
||||
public function testIgbinaryUnserialize()
|
||||
{
|
||||
if (\PHP_VERSION_ID === 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.0.');
|
||||
if (\PHP_VERSION_ID >= 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
|
||||
}
|
||||
|
||||
$marshaller = new DefaultMarshaller();
|
||||
@ -67,8 +67,8 @@ class DefaultMarshallerTest extends TestCase
|
||||
*/
|
||||
public function testIgbinaryUnserializeNotFoundClass()
|
||||
{
|
||||
if (\PHP_VERSION_ID === 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.0.');
|
||||
if (\PHP_VERSION_ID >= 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
|
||||
}
|
||||
|
||||
$this->expectException('DomainException');
|
||||
@ -95,8 +95,8 @@ class DefaultMarshallerTest extends TestCase
|
||||
*/
|
||||
public function testIgbinaryUnserializeInvalid()
|
||||
{
|
||||
if (\PHP_VERSION_ID === 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.0');
|
||||
if (\PHP_VERSION_ID >= 70400) {
|
||||
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
|
||||
}
|
||||
|
||||
$this->expectException('DomainException');
|
||||
|
Reference in New Issue
Block a user