diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #32984 [HttpClient] Relax max duration test assertion (fancyweb) 

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Relax max duration test assertion

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

cf https://travis-ci.org/symfony/symfony/jobs/568304532 - It looks like with the curl client, the actual duration can be a little less than the configured max duration. Note that the same test did not fail on the PR...

Commits
-------

3cbb978b00 [HttpClient] Relax max duration test assertion
This commit is contained in:
Nicolas Grekas 2019-08-06 14:20:22 +02:00
parent b4bb8e833d 3cbb978b00
commit b59c8654b5
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php
View File

@ -795,7 +795,6 @@ abstract class HttpClientTestCase extends TestCase
$duration = microtime(true) - $start;
$this->assertGreaterThanOrEqual(0.1, $duration);
$this->assertLessThan(0.2, $duration);
$this->assertLessThan(10, $duration);
}
}