Fix the 'supports' method argument type of the security voter
This commit is contained in:
parent
2caadf17b4
commit
b8192eecab
@ -30,9 +30,22 @@ abstract class Voter implements VoterInterface
|
||||
$vote = self::ACCESS_ABSTAIN;
|
||||
|
||||
foreach ($attributes as $attribute) {
|
||||
try {
|
||||
if (!$this->supports($attribute, $subject)) {
|
||||
continue;
|
||||
}
|
||||
} catch (\TypeError $e) {
|
||||
if (\PHP_VERSION_ID < 80000) {
|
||||
if (0 === strpos($e->getMessage(), 'Argument 1 passed to')
|
||||
&& false !== strpos($e->getMessage(), '::supports() must be of the type string')) {
|
||||
continue;
|
||||
}
|
||||
} elseif (false !== strpos($e->getMessage(), 'supports(): Argument #1')) {
|
||||
continue;
|
||||
}
|
||||
|
||||
throw $e;
|
||||
}
|
||||
|
||||
// as soon as at least one attribute is supported, default is to deny access
|
||||
$vote = self::ACCESS_DENIED;
|
||||
|
@ -27,34 +27,49 @@ class VoterTest extends TestCase
|
||||
|
||||
public function getTests()
|
||||
{
|
||||
$voter = new VoterTest_Voter();
|
||||
$integerVoter = new IntegerVoterTest_Voter();
|
||||
|
||||
return [
|
||||
[['EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if attribute and class are supported and attribute grants access'],
|
||||
[['CREATE'], VoterInterface::ACCESS_DENIED, new \stdClass(), 'ACCESS_DENIED if attribute and class are supported and attribute does not grant access'],
|
||||
[$voter, ['EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if attribute and class are supported and attribute grants access'],
|
||||
[$voter, ['CREATE'], VoterInterface::ACCESS_DENIED, new \stdClass(), 'ACCESS_DENIED if attribute and class are supported and attribute does not grant access'],
|
||||
|
||||
[['DELETE', 'EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if one attribute is supported and grants access'],
|
||||
[['DELETE', 'CREATE'], VoterInterface::ACCESS_DENIED, new \stdClass(), 'ACCESS_DENIED if one attribute is supported and denies access'],
|
||||
[$voter, ['DELETE', 'EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if one attribute is supported and grants access'],
|
||||
[$voter, ['DELETE', 'CREATE'], VoterInterface::ACCESS_DENIED, new \stdClass(), 'ACCESS_DENIED if one attribute is supported and denies access'],
|
||||
|
||||
[['CREATE', 'EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if one attribute grants access'],
|
||||
[$voter, ['CREATE', 'EDIT'], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if one attribute grants access'],
|
||||
|
||||
[['DELETE'], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if no attribute is supported'],
|
||||
[$voter, ['DELETE'], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if no attribute is supported'],
|
||||
|
||||
[['EDIT'], VoterInterface::ACCESS_ABSTAIN, $this, 'ACCESS_ABSTAIN if class is not supported'],
|
||||
[$voter, ['EDIT'], VoterInterface::ACCESS_ABSTAIN, $this, 'ACCESS_ABSTAIN if class is not supported'],
|
||||
|
||||
[['EDIT'], VoterInterface::ACCESS_ABSTAIN, null, 'ACCESS_ABSTAIN if object is null'],
|
||||
[$voter, ['EDIT'], VoterInterface::ACCESS_ABSTAIN, null, 'ACCESS_ABSTAIN if object is null'],
|
||||
|
||||
[[], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if no attributes were provided'],
|
||||
[$voter, [], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if no attributes were provided'],
|
||||
|
||||
[$voter, [new StringableAttribute()], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if attribute and class are supported and attribute grants access'],
|
||||
|
||||
[$voter, [new \stdClass()], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if attributes were not strings'],
|
||||
|
||||
[$integerVoter, [42], VoterInterface::ACCESS_GRANTED, new \stdClass(), 'ACCESS_GRANTED if attribute is an integer'],
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider getTests
|
||||
*/
|
||||
public function testVote(array $attributes, $expectedVote, $object, $message)
|
||||
public function testVote(VoterInterface $voter, array $attributes, $expectedVote, $object, $message)
|
||||
{
|
||||
$voter = new VoterTest_Voter();
|
||||
|
||||
$this->assertEquals($expectedVote, $voter->vote($this->token, $object, $attributes), $message);
|
||||
}
|
||||
|
||||
public function testVoteWithTypeError()
|
||||
{
|
||||
$this->expectException('TypeError');
|
||||
$this->expectExceptionMessage('Should error');
|
||||
$voter = new TypeErrorVoterTest_Voter();
|
||||
$voter->vote($this->token, new \stdClass(), ['EDIT']);
|
||||
}
|
||||
}
|
||||
|
||||
class VoterTest_Voter extends Voter
|
||||
@ -69,3 +84,37 @@ class VoterTest_Voter extends Voter
|
||||
return $object instanceof \stdClass && \in_array($attribute, ['EDIT', 'CREATE']);
|
||||
}
|
||||
}
|
||||
|
||||
class IntegerVoterTest_Voter extends Voter
|
||||
{
|
||||
protected function voteOnAttribute($attribute, $object, TokenInterface $token): bool
|
||||
{
|
||||
return 42 === $attribute;
|
||||
}
|
||||
|
||||
protected function supports($attribute, $object): bool
|
||||
{
|
||||
return $object instanceof \stdClass && \is_int($attribute);
|
||||
}
|
||||
}
|
||||
|
||||
class TypeErrorVoterTest_Voter extends Voter
|
||||
{
|
||||
protected function voteOnAttribute($attribute, $object, TokenInterface $token): bool
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
protected function supports($attribute, $object): bool
|
||||
{
|
||||
throw new \TypeError('Should error');
|
||||
}
|
||||
}
|
||||
|
||||
class StringableAttribute
|
||||
{
|
||||
public function __toString(): string
|
||||
{
|
||||
return 'EDIT';
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user