diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #39706 [HttpKernel] harden test to not depend on the actual time (xabbuh)

Browse Source 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] harden test to not depend on the actual time

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

From time to time this test fails (e.g. https://travis-ci.com/github/symfony/symfony/jobs/468014427#L7092). We can fix that by not depending on the system clock which is actually not needed in this test.

Commits
-------

28a956baa9 harden test to not depend on the actual time
This commit is contained in:
Fabien Potencier 2021-01-04 13:01:41 +01:00
commit b9bdb8e5ed
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Symfony/Component/HttpKernel/Tests/Profiler/FileProfilerStorageTest.php
View File

@ -190,26 +190,25 @@ class FileProfilerStorageTest extends TestCase
public function testStoreTime()
{
$dt = new \DateTime('now');
$start = $dt->getTimestamp();
$start = $now = time();
for ($i = 0; $i < 3; ++$i) {
$dt->modify('+1 minute');
$now += 60;
$profile = new Profile('time_'.$i);
$profile->setIp('127.0.0.1');
$profile->setUrl('http://foo.bar');
$profile->setTime($dt->getTimestamp());
$profile->setTime($now);
$profile->setMethod('GET');
$this->storage->write($profile);
}
$records = $this->storage->find('', '', 3, 'GET', $start, time() + 3 * 60);
$records = $this->storage->find('', '', 3, 'GET', $start, $start + 3 * 60);
$this->assertCount(3, $records, '->find() returns all previously added records');
$this->assertEquals('time_2', $records[0]['token'], '->find() returns records ordered by time in descendant order');
$this->assertEquals('time_1', $records[1]['token'], '->find() returns records ordered by time in descendant order');
$this->assertEquals('time_0', $records[2]['token'], '->find() returns records ordered by time in descendant order');
$records = $this->storage->find('', '', 3, 'GET', $start, time() + 2 * 60);
$records = $this->storage->find('', '', 3, 'GET', $start, $start + 2 * 60);
$this->assertCount(2, $records, '->find() should return only first two of the previously added records');
}