merged branch Burgov/builder_getparent_call_fix (PR #4556)
Commits -------1e83206
[Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore) Discussion ---------- [Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore) Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes --------------------------------------------------------------------------- by travisbot at 2012-06-12T13:43:25Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601018) (merged 9826ca66 into77839690
). --------------------------------------------------------------------------- by travisbot at 2012-06-12T13:51:33Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1601030) (merged1e83206e
into77839690
). --------------------------------------------------------------------------- by bschussek at 2012-06-12T18:21:56Z 👍 Thanks again! :)
This commit is contained in:
commit
ba8333a5b2
@ -172,11 +172,7 @@ class FormFactory implements FormFactoryInterface
|
||||
|
||||
array_unshift($types, $type);
|
||||
|
||||
// getParent() cannot see default options set by this type nor
|
||||
// default options set by parent types
|
||||
// As a result, the options always have to be checked for
|
||||
// existence with isset() before using them in this method.
|
||||
$type = $type->getParent($options);
|
||||
$type = $type->getParent();
|
||||
}
|
||||
|
||||
// Top-down determination of the default options
|
||||
|
Reference in New Issue
Block a user