diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #21784 [Workflow] Remove unnecessary method calls (izzyp)

Browse Source 
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #21784).

Discussion
----------

[Workflow] Remove unnecessary method calls

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| License       | MIT

getEnabledTransitions() method only requires 1 parameter "$subject".

Removed places where a second parameter "$this->getMarking($subject)" is being passed to getEnabledTransitions().

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

12d9129 [Workflow] Remove unnecessary method calls
This commit is contained in:
Nicolas Grekas 2017-02-28 15:33:16 +01:00
commit bbb17df480
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Symfony/Component/Workflow/Workflow.php
View File

@ -61,6 +61,9 @@ class Workflow
throw new LogicException(sprintf('The Marking is empty and there is no initial place for workflow "%s".', $this->name));
}
$marking->mark($this->definition->getInitialPlace());
// update the subject with the new marking
$this->markingStore->setMarking($subject, $marking);
}
// check that the subject has a known place
@ -76,9 +79,6 @@ class Workflow
}
}
// Because the marking could have been initialized, we update the subject
$this->markingStore->setMarking($subject, $marking);
return $marking;
}
@ -92,7 +92,7 @@ class Workflow
*/
public function can($subject, $transitionName)
{
$transitions = $this->getEnabledTransitions($subject, $this->getMarking($subject));
$transitions = $this->getEnabledTransitions($subject);
foreach ($transitions as $transition) {
if ($transitionName === $transition->getName()) {
@ -116,7 +116,7 @@ class Workflow
*/
public function apply($subject, $transitionName)
{
$transitions = $this->getEnabledTransitions($subject, $this->getMarking($subject));
$transitions = $this->getEnabledTransitions($subject);
// We can shortcut the getMarking method in order to boost performance,
// since the "getEnabledTransitions" method already checks the Marking