diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Form] Fixed behavior of expanded multiple-choice field when submitted without ticks

Browse Source
This commit is contained in:
Bernhard Schussek 2012-04-10 17:42:05 +02:00
parent 2e07256921
commit bc9bc4af5d
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Form/Extension/Core/EventListener/FixCheckboxInputListener.php
View File

@ -41,7 +41,7 @@ class FixCheckboxInputListener implements EventSubscriberInterface
$values = (array) $event->getData();
$indices = $this->choiceList->getIndicesForValues($values);
$event->setData(array_combine($indices, $values));
$event->setData(count($indices) > 0 ? array_combine($indices, $values) : array());
}
static public function getSubscribedEvents()

23
src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
View File

@ -399,6 +399,29 @@ class ChoiceTypeTest extends TypeTestCase
$this->assertNull($form[4]->getClientData());
}
public function testBindMultipleExpandedEmpty()
{
$form = $this->factory->create('choice', null, array(
'multiple' => true,
'expanded' => true,
'choices' => $this->choices,
));
$form->bind(array());
$this->assertSame(array(), $form->getData());
$this->assertFalse($form[0]->getData());
$this->assertFalse($form[1]->getData());
$this->assertFalse($form[2]->getData());
$this->assertFalse($form[3]->getData());
$this->assertFalse($form[4]->getData());
$this->assertNull($form[0]->getClientData());
$this->assertNull($form[1]->getClientData());
$this->assertNull($form[2]->getClientData());
$this->assertNull($form[3]->getClientData());
$this->assertNull($form[4]->getClientData());
}
public function testBindMultipleExpandedWithEmptyField()
{
$form = $this->factory->create('choice', null, array(