diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #35288 [Console] Fix SymfonyQuestionHelper tests sometimes failing on AppVeyor (fancyweb)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix SymfonyQuestionHelper tests sometimes failing on AppVeyor

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/35035
| License       | MIT
| Doc PR        | -

The test uses heredoc for the expected part. Expected line returns are `"\n"` because that's how they are written in the source code file.
However, on Windows, the console outputs `"\r\n"` (`PHP_EOL`) for new lines.
`"qqq:\r\n"` does not contain `"qqq:\n"`.

I'm still wondering why this test is not *always* failing...

Commits
-------

474f3bef08 [Console] Fix SymfonyQuestionHelper tests sometimes failing on AppVeyor
This commit is contained in:
Fabien Potencier 2020-01-10 09:03:47 +01:00
commit c192a0c2fb
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Symfony/Component/Console/Tests/Helper/SymfonyQuestionHelperTest.php
View File

@ -145,13 +145,13 @@ class SymfonyQuestionHelperTest extends AbstractQuestionHelperTest
); );
$this->assertOutputContains(<<<EOT $this->assertOutputContains(<<<EOT
qqq: qqq:
[foo ] foo [foo ] foo
[żółw ] bar [żółw ] bar
[łabądź] baz [łabądź] baz
> >
EOT EOT
, $output); , $output, true);
} }
public function testChoiceQuestionCustomPrompt() public function testChoiceQuestionCustomPrompt()
@ -168,9 +168,9 @@ EOT
$this->assertOutputContains(<<<EOT $this->assertOutputContains(<<<EOT
qqq: qqq:
[0] foo [0] foo
>ccc> >ccc>
EOT EOT
, $output); , $output, true);
} }
protected function getInputStream($input) protected function getInputStream($input)
@ -200,10 +200,15 @@ EOT
return $mock; return $mock;
} }
private function assertOutputContains($expected, StreamOutput $output) private function assertOutputContains($expected, StreamOutput $output, $normalize = false)
{ {
rewind($output->getStream()); rewind($output->getStream());
$stream = stream_get_contents($output->getStream()); $stream = stream_get_contents($output->getStream());
if ($normalize) {
$stream = str_replace(PHP_EOL, "\n", $stream);
}
$this->assertStringContainsString($expected, $stream); $this->assertStringContainsString($expected, $stream);
} }
} }