diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Filesystem] Cleanup/sync with 2.3

Browse Source
This commit is contained in:
Nicolas Grekas 2016-03-08 08:52:42 +01:00
parent 81c50d628e
commit c417d7a1a5
2 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
View File

@ -347,7 +347,7 @@ class FilesystemTest extends FilesystemTestCase
// create symlink to nonexistent dir // create symlink to nonexistent dir
rmdir($basePath.'dir'); rmdir($basePath.'dir');
$this->assertFalse(is_dir($basePath.'dir-link')); $this->assertFalse('\\' === DIRECTORY_SEPARATOR ? @readlink($basePath.'dir-link') : is_dir($basePath.'dir-link'));
$this->filesystem->remove($basePath); $this->filesystem->remove($basePath);
@ -383,7 +383,7 @@ class FilesystemTest extends FilesystemTestCase
$file = str_repeat('T', 259 - strlen($basePath)); $file = str_repeat('T', 259 - strlen($basePath));
$path = $basePath.$file; $path = $basePath.$file;
exec('TYPE NUL >>'.$file); // equivalent of touch, we can not use the php touch() here because it suffers from the same limitation exec('TYPE NUL >>'.$file); // equivalent of touch, we can not use the php touch() here because it suffers from the same limitation
self::$longPathNamesWindows[] = $path; // save this so we can clean up later $this->longPathNamesWindows[] = $path; // save this so we can clean up later
chdir($oldPath); chdir($oldPath);
$this->filesystem->exists($path); $this->filesystem->exists($path);
} }

21
src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php
View File

@ -17,7 +17,7 @@ class FilesystemTestCase extends \PHPUnit_Framework_TestCase
{ {
private $umask; private $umask;
static protected $longPathNamesWindows = array(); protected $longPathNamesWindows = array();
/** /**
* @var \Symfony\Component\Filesystem\Filesystem * @var \Symfony\Component\Filesystem\Filesystem
@ -33,12 +33,6 @@ class FilesystemTestCase extends \PHPUnit_Framework_TestCase
public static function setUpBeforeClass() public static function setUpBeforeClass()
{ {
if (!empty(self::$longPathNamesWindows)) {
foreach (self::$longPathNamesWindows as $path) {
exec('DEL '.$path);
}
}
if ('\\' === DIRECTORY_SEPARATOR && null === self::$symlinkOnWindows) { if ('\\' === DIRECTORY_SEPARATOR && null === self::$symlinkOnWindows) {
$target = tempnam(sys_get_temp_dir(), 'sl'); $target = tempnam(sys_get_temp_dir(), 'sl');
$link = sys_get_temp_dir().'/sl'.microtime(true).mt_rand(); $link = sys_get_temp_dir().'/sl'.microtime(true).mt_rand();
@ -52,14 +46,21 @@ class FilesystemTestCase extends \PHPUnit_Framework_TestCase
protected function setUp() protected function setUp()
{ {
$this->umask = umask(0); $this->umask = umask(0);
$this->filesystem = new Filesystem();
$this->workspace = rtrim(sys_get_temp_dir(), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.time().mt_rand(0, 1000); $this->workspace = rtrim(sys_get_temp_dir(), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.time().mt_rand(0, 1000);
mkdir($this->workspace, 0777, true); mkdir($this->workspace, 0777, true);
$this->workspace = realpath($this->workspace); $this->workspace = realpath($this->workspace);
$this->filesystem = new Filesystem();
} }
protected function tearDown() protected function tearDown()
{ {
if (!empty($this->longPathNamesWindows)) {
foreach ($this->longPathNamesWindows as $path) {
exec('DEL '.$path);
}
$this->longPathNamesWindows = array();
}
$this->filesystem->remove($this->workspace); $this->filesystem->remove($this->workspace);
umask($this->umask); umask($this->umask);
} }
@ -102,10 +103,6 @@ class FilesystemTestCase extends \PHPUnit_Framework_TestCase
protected function markAsSkippedIfSymlinkIsMissing($relative = false) protected function markAsSkippedIfSymlinkIsMissing($relative = false)
{ {
if (!function_exists('symlink')) {
$this->markTestSkipped('Function symlink is required.');
}
if ('\\' === DIRECTORY_SEPARATOR && false === self::$symlinkOnWindows) { if ('\\' === DIRECTORY_SEPARATOR && false === self::$symlinkOnWindows) {
$this->markTestSkipped('symlink requires "Create symbolic links" privilege on Windows'); $this->markTestSkipped('symlink requires "Create symbolic links" privilege on Windows');
} }