diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #23958 [Lock] Fix race condition in tests between cache and lock component (jderusse)

Browse Source 
This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #23958).

Discussion
----------

[Lock] Fix race condition in tests between cache and lock component

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently trying to fix
* [x] php 5.5 in testSaveWithDifferentResources "Failed asserting that false is true"
* [x] php 5.5 in testSaveWithDifferentKeysOnSameResources "The store shouldn't save the second key"

Workflow:
* [x] find a reproducer
* [x] fix memcached tests => #23969
* [x] fix redis tests => this PR

Commits
-------

26948cf Fix race condition in tests between cache and lock
This commit is contained in:
Nicolas Grekas 2017-09-03 16:06:51 +02:00
commit c4ecb9c75d
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php
View File

@ -41,7 +41,6 @@ abstract class AbstractRedisAdapterTest extends AdapterTestCase
public static function tearDownAfterClass()
{
self::$redis->flushDB();
self::$redis = null;
}
}

1
src/Symfony/Component/Cache/Tests/Adapter/PredisClusterAdapterTest.php
View File

@ -21,7 +21,6 @@ class PredisClusterAdapterTest extends AbstractRedisAdapterTest
public static function tearDownAfterClass()
{
self::$redis->getConnection()->getConnectionByKey('foo')->executeCommand(self::$redis->createCommand('FLUSHDB'));
self::$redis = null;
}
}

1
src/Symfony/Component/Cache/Tests/Simple/AbstractRedisCacheTest.php
View File

@ -41,7 +41,6 @@ abstract class AbstractRedisCacheTest extends CacheTestCase
public static function tearDownAfterClass()
{
self::$redis->flushDB();
self::$redis = null;
}
}