diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #32164 [EventDispatcher] collect called listeners information only once (xabbuh)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] collect called listeners information only once

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

2ad32df6e0 collect called listeners information only once
This commit is contained in:
Fabien Potencier 2019-06-26 08:45:17 +02:00
commit c511e46c73
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
View File

@ -191,21 +191,18 @@ class TraceableEventDispatcher implements TraceableEventDispatcherInterface
return []; return [];
} }
$calledListeners = [];
if (null !== $this->callStack) {
foreach ($this->callStack as $calledListener) {
$calledListeners[] = $calledListener->getWrappedListener();
}
}
$notCalled = []; $notCalled = [];
foreach ($allListeners as $eventName => $listeners) { foreach ($allListeners as $eventName => $listeners) {
foreach ($listeners as $listener) { foreach ($listeners as $listener) {
$called = false; if (!\in_array($listener, $calledListeners, true)) {
if (null !== $this->callStack) {
foreach ($this->callStack as $calledListener) {
if ($calledListener->getWrappedListener() === $listener) {
$called = true;
break;
}
}
}
if (!$called) {
if (!$listener instanceof WrappedListener) { if (!$listener instanceof WrappedListener) {
$listener = new WrappedListener($listener, null, $this->stopwatch, $this); $listener = new WrappedListener($listener, null, $this->stopwatch, $this);
} }