diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Security] Revise UserPasswordEncoderInterface::needsRehash()

Browse Source
This commit is contained in:
Roland Franssen 2019-07-31 15:42:59 +02:00 committed by Nicolas Grekas
parent 40fe1610d2
commit c5a283d417
4 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Security/Core/Encoder/UserPasswordEncoder.php
View File

@ -50,10 +50,10 @@ class UserPasswordEncoder implements UserPasswordEncoderInterface
/**
* {@inheritdoc}
*/
public function needsRehash(UserInterface $user, string $encoded): bool
public function needsRehash(UserInterface $user): bool
{
$encoder = $this->encoderFactory->getEncoder($user);
return method_exists($encoder, 'needsRehash') && $encoder->needsRehash($encoded);
return method_exists($encoder, 'needsRehash') && $encoder->needsRehash($user->getPassword());
}
}

2
src/Symfony/Component/Security/Core/Encoder/UserPasswordEncoderInterface.php
View File

@ -18,7 +18,7 @@ use Symfony\Component\Security\Core\User\UserInterface;
*
* @author Ariel Ferrandini <arielferrandini@gmail.com>
*
* @method bool needsRehash(UserInterface $user, string $encoded)
* @method bool needsRehash(UserInterface $user)
*/
interface UserPasswordEncoderInterface
{

8
src/Symfony/Component/Security/Core/Tests/Encoder/UserPasswordEncoderTest.php
View File

@ -85,9 +85,9 @@ class UserPasswordEncoderTest extends TestCase
$passwordEncoder = new UserPasswordEncoder($mockEncoderFactory);
$hash = $passwordEncoder->encodePassword($user, 'foo', 'salt');
$this->assertFalse($passwordEncoder->needsRehash($user, $hash));
$this->assertTrue($passwordEncoder->needsRehash($user, $hash));
$this->assertFalse($passwordEncoder->needsRehash($user, $hash));
$user->setPassword($passwordEncoder->encodePassword($user, 'foo', 'salt'));
$this->assertFalse($passwordEncoder->needsRehash($user));
$this->assertTrue($passwordEncoder->needsRehash($user));
$this->assertFalse($passwordEncoder->needsRehash($user));
}
}

5
src/Symfony/Component/Security/Core/User/User.php
View File

@ -164,4 +164,9 @@ final class User implements UserInterface, EquatableInterface, AdvancedUserInter
return true;
}
public function setPassword(string $password)
{
$this->password = $password;
}
}