diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch TerjeBr/persistent-token-provider (PR #7534) 

This PR was merged into the 2.2 branch.

Discussion
----------

[Security/Http/RememberMe] PersistentTokenBasedRememberMeServices bugfix

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass? | yes
| License       | MIT

The database and debug layer cannot handle raw random strings. It may contain invalid ut8 characters and whatnot. So, in order to avoid a lot of database bugs, we must base64_encode the random strings.

Commits
-------

751abe1 Doctrine cannot handle bare random non-utf8 strings
This commit is contained in:
Fabien Potencier 2013-04-01 09:55:23 +02:00
parent b70bb448fa 751abe10d5
commit c65b482a69
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Symfony/Component/Security/Http/RememberMe/PersistentTokenBasedRememberMeServices.php
View File

@ -99,7 +99,7 @@ class PersistentTokenBasedRememberMeServices extends AbstractRememberMeServices
} }
$series = $persistentToken->getSeries(); $series = $persistentToken->getSeries();
$tokenValue = $this->secureRandom->nextBytes(64); $tokenValue = base64_encode($this->secureRandom->nextBytes(64));
$this->tokenProvider->updateToken($series, $tokenValue, new \DateTime()); $this->tokenProvider->updateToken($series, $tokenValue, new \DateTime());
$request->attributes->set(self::COOKIE_ATTR_NAME, $request->attributes->set(self::COOKIE_ATTR_NAME,
new Cookie( new Cookie(
@ -121,8 +121,8 @@ class PersistentTokenBasedRememberMeServices extends AbstractRememberMeServices
*/ */
protected function onLoginSuccess(Request $request, Response $response, TokenInterface $token) protected function onLoginSuccess(Request $request, Response $response, TokenInterface $token)
{ {
$series = $this->secureRandom->nextBytes(64); $series = base64_encode($this->secureRandom->nextBytes(64));
$tokenValue = $this->secureRandom->nextBytes(64); $tokenValue = base64_encode($this->secureRandom->nextBytes(64));
$this->tokenProvider->createNewToken( $this->tokenProvider->createNewToken(
new PersistentToken( new PersistentToken(