diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #30034 [Config] ensure moving away from Serializable wont break cache:clear (nicolas-grekas) 

This PR was merged into the 3.4 branch.

Discussion
----------

[Config] ensure moving away from Serializable wont break cache:clear

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

When a resource implementation moves away from `Serializable`, the `cache:clear` command currently fails with `Warning: Class Symfony\Component\Config\Resource\ClassExistenceResource has no unserializer`. This change makes it ignore the failure, which is fine.

Commits
-------

9d3180a7e2 [Config] ensure moving away from Serializable wont break cache:clear
This commit is contained in:
Nicolas Grekas 2019-01-30 12:20:19 +01:00
parent 3cfb558f03 9d3180a7e2
commit c7937c9749
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Config/ResourceCheckerConfigCache.php
View File

@ -156,10 +156,11 @@ class ResourceCheckerConfigCache implements ConfigCacheInterface
{
$e = null;
$meta = false;
$content = file_get_contents($file);
$signalingException = new \UnexpectedValueException();
$prevUnserializeHandler = ini_set('unserialize_callback_func', '');
$prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler, $signalingException) {
if (E_WARNING === $type && 'Class __PHP_Incomplete_Class has no unserializer' === $msg) {
if (__FILE__ === $file) {
throw $signalingException;
}
@ -167,7 +168,7 @@ class ResourceCheckerConfigCache implements ConfigCacheInterface
});
try {
$meta = unserialize(file_get_contents($file));
$meta = unserialize($content);
} catch (\Error $e) {
} catch (\Exception $e) {
}