minor #16946 Clean useless deprecation silencing (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

Clean useless deprecation silencing

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We added these when we triggered unsilenced notices. But we silence them now.

Commits
-------

9953550 Clean useless deprecation silencing

src/Symfony/Bundle/FrameworkBundle/Client.php

@@ -165,7 +165,7 @@ class Client extends BaseClient
         $code = <<<EOF
 <?php
 
-error_reporting($errorReporting & ~E_USER_DEPRECATED);
+error_reporting($errorReporting);
 
 if ('$autoloader') {
     require_once '$autoloader';

src/Symfony/Bundle/TwigBundle/Tests/TokenParser/LegacyRenderTokenParserTest.php

@@ -20,11 +20,6 @@ use Symfony\Bundle\TwigBundle\Node\RenderNode;
  */
 class LegacyRenderTokenParserTest extends TestCase
 {
-    protected function setUp()
-    {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-    }
-
     /**
      * @dataProvider getTestsForRender
      */

src/Symfony/Component/Form/Tests/AbstractLayoutTest.php

@@ -127,8 +127,6 @@ abstract class AbstractLayoutTest extends \Symfony\Component\Form\Test\FormInteg
      */
     public function testLegacyEnctype()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         $form = $this->factory->createNamedBuilder('name', 'form')
             ->add('file', 'file')
             ->getForm();
@@ -141,8 +139,6 @@ abstract class AbstractLayoutTest extends \Symfony\Component\Form\Test\FormInteg
      */
     public function testLegacyNoEnctype()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         $form = $this->factory->createNamedBuilder('name', 'form')
             ->add('text', 'text')
             ->getForm();

src/Symfony/Component/Form/Tests/Extension/Csrf/CsrfProvider/DefaultCsrfProviderTest.php

@@ -25,7 +25,6 @@ class DefaultCsrfProviderTest extends \PHPUnit_Framework_TestCase
     {
         ini_set('session.save_handler', 'files');
         ini_set('session.save_path', sys_get_temp_dir());
-        ini_set('error_reporting', -1 & ~E_USER_DEPRECATED);
     }
 
     protected function setUp()

src/Symfony/Component/Form/Tests/Extension/HttpFoundation/EventListener/LegacyBindRequestListenerTest.php

@@ -37,8 +37,6 @@ class LegacyBindRequestListenerTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         $path = tempnam(sys_get_temp_dir(), 'sf2');
         touch($path);
 

src/Symfony/Component/HttpKernel/Client.php

@@ -105,7 +105,7 @@ class Client extends BaseClient
         $code = <<<EOF
 <?php
 
-error_reporting($errorReporting & ~E_USER_DEPRECATED);
+error_reporting($errorReporting);
 
 require_once '$requirePath';
 

src/Symfony/Component/Locale/Tests/LocaleTest.php

@@ -22,8 +22,6 @@ class LocaleTest extends \PHPUnit_Framework_TestCase
 {
     protected function setUp()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         \Locale::setDefault('en');
     }
 

src/Symfony/Component/Locale/Tests/Stub/StubLocaleTest.php

@@ -18,11 +18,6 @@ use Symfony\Component\Locale\Stub\StubLocale;
  */
 class StubLocaleTest extends \PHPUnit_Framework_TestCase
 {
-    protected function setUp()
-    {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-    }
-
     public function testGetCurrenciesData()
     {
         $currencies = StubLocale::getCurrenciesData('en');

src/Symfony/Component/Routing/Tests/Annotation/RouteTest.php

@@ -51,8 +51,6 @@ class RouteTest extends \PHPUnit_Framework_TestCase
      */
     public function testLegacyGetPattern()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         $route = new Route(array('value' => '/Blog'));
         $this->assertEquals($route->getPattern(), '/Blog');
     }

src/Symfony/Component/Routing/Tests/RouteTest.php

@@ -206,8 +206,6 @@ class RouteTest extends \PHPUnit_Framework_TestCase
      */
     public function testLegacyPattern()
     {
-        $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
-
         $route = new Route('/{foo}');
         $this->assertEquals('/{foo}', $route->getPattern());