diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #30788 [Mailer] Remove unneeded catch in ping() (sstok)

Browse Source 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Mailer] Remove unneeded catch in ping()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes?
| Fixed tickets |
| License       | MIT
| Doc PR        |

The stop() method doesn't throw.

Commits
-------

907adf47e3 [Mailer] Remove unneeded catch in ping()
This commit is contained in:
Fabien Potencier 2019-03-30 17:00:28 +01:00
commit c9b8ca631c
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php
View File

@ -219,10 +219,7 @@ class SmtpTransport extends AbstractTransport
try {
$this->executeCommand("NOOP\r\n", [250]);
} catch (TransportExceptionInterface $e) {
try {
$this->stop();
} catch (TransportExceptionInterface $e) {
}
$this->stop();
}
}