diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #9720 [FrameworkBundle] avoid tables to have apparently long blank line breaks and be too far appart for long nested array params (cordoval)

Browse Source 
This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes #9720).

Discussion
----------

[FrameworkBundle] avoid tables to have apparently long blank line breaks and be too far appart for long nested array params

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | na

This PR fixes the uncomfortable long parameter array dumps on the tables, if one needs to see the details of a parameter they can do so by inspecting the specific parameter rather than having all the info in the table and render it out of whack.

Commits
-------

a588ece avoid tables to have apparently long blank line breaks and be too far appart for long nested array params
This commit is contained in:
Fabien Potencier 2013-12-27 22:07:28 +01:00
commit ca1f3d7c82
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
View File

@ -198,7 +198,17 @@ abstract class Descriptor implements DescriptorInterface
protected function formatParameter($value)
{
if (is_bool($value) || is_array($value) || (null === $value)) {
return json_encode($value);
$jsonString = json_encode($value);
if (!function_exists('mb_strlen')) {
return substr($jsonString, 0, 60).(strlen($jsonString) > 60 ? ' ...' : '');
}
if (mb_strlen($jsonString) > 60) {
return mb_substr($jsonString, 0, 60).' ...';
}
return $jsonString;
}
return (string) $value;