diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[DoctrineBridge] Fixed caching in DoctrineType when "choices" or "preferred_choices" is passed

Browse Source
This commit is contained in:
Bernhard Schussek 2012-12-06 19:23:55 +01:00
parent 864cc8598f
commit ca5d9acb19
2 changed files with 47 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php
View File

@ -77,16 +77,16 @@ abstract class DoctrineType extends AbstractType
// A second parameter ($key) is passed, so we cannot use // A second parameter ($key) is passed, so we cannot use
// spl_object_hash() directly (which strictly requires // spl_object_hash() directly (which strictly requires
// one parameter) // one parameter)
array_walk_recursive($choiceHashes, function ($value) { array_walk_recursive($choiceHashes, function (&$value) {
return spl_object_hash($value); $value = spl_object_hash($value);
}); });
} }
$preferredChoiceHashes = $options['preferred_choices']; $preferredChoiceHashes = $options['preferred_choices'];
if (is_array($preferredChoiceHashes)) { if (is_array($preferredChoiceHashes)) {
array_walk_recursive($preferredChoiceHashes, function ($value) { array_walk_recursive($preferredChoiceHashes, function (&$value) {
return spl_object_hash($value); $value = spl_object_hash($value);
}); });
} }

45
src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypePerformanceTest.php
View File

@ -104,7 +104,7 @@ class EntityTypePerformanceTest extends FormPerformanceTestCase
{ {
$this->setMaxRunningTime(1); $this->setMaxRunningTime(1);
for ($i = 0; $i < 20; ++$i) { for ($i = 0; $i < 40; ++$i) {
$form = $this->factory->create('entity', null, array( $form = $this->factory->create('entity', null, array(
'class' => self::ENTITY_CLASS, 'class' => self::ENTITY_CLASS,
)); ));
@ -114,11 +114,14 @@ class EntityTypePerformanceTest extends FormPerformanceTestCase
} }
} }
/**
* @group benchmark
*/
public function testCollapsedEntityFieldWithQueryBuilder() public function testCollapsedEntityFieldWithQueryBuilder()
{ {
$this->setMaxRunningTime(1); $this->setMaxRunningTime(1);
for ($i = 0; $i < 20; ++$i) { for ($i = 0; $i < 40; ++$i) {
$form = $this->factory->create('entity', null, array( $form = $this->factory->create('entity', null, array(
'class' => self::ENTITY_CLASS, 'class' => self::ENTITY_CLASS,
'query_builder' => function (EntityRepository $repo) { 'query_builder' => function (EntityRepository $repo) {
@ -130,4 +133,42 @@ class EntityTypePerformanceTest extends FormPerformanceTestCase
$form->createView(); $form->createView();
} }
} }
/**
* @group benchmark
*/
public function testCollapsedEntityFieldWithChoices()
{
$choices = $this->em->createQuery('SELECT c FROM ' . self::ENTITY_CLASS . ' c')->getResult();
$this->setMaxRunningTime(1);
for ($i = 0; $i < 40; ++$i) {
$form = $this->factory->create('entity', null, array(
'class' => self::ENTITY_CLASS,
'choices' => $choices,
));
// force loading of the choice list
$form->createView();
}
}
/**
* @group benchmark
*/
public function testCollapsedEntityFieldWithPreferredChoices()
{
$choices = $this->em->createQuery('SELECT c FROM ' . self::ENTITY_CLASS . ' c')->getResult();
$this->setMaxRunningTime(1);
for ($i = 0; $i < 40; ++$i) {
$form = $this->factory->create('entity', null, array(
'class' => self::ENTITY_CLASS,
'preferred_choices' => $choices,
));
// force loading of the choice list
$form->createView();
}
}
} }