bug #28664 [Console] Don't return early as this bypasses the auto exit feature (duncan3dc)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Don't return early as this bypasses the auto exit feature

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets |
| License       | MIT

It looks like 8805cfdf8d broke the auto exit feature by returning early.

I couldn't find any tests for this feature (presumably because it uses `exit()`), I was going to write one using uopz but didn't want to do this work if Symfony intentionally doesn't test the call to `exit()`

Commits
-------

b6c17df Don't return early as this bypasses the auto exit feature
This commit is contained in:
Robin Chalas 2018-10-01 18:00:22 +02:00
commit caf37ca375

View File

@ -162,8 +162,6 @@ class Application
} else {
$exitCode = 1;
}
return $exitCode;
} finally {
// if the exception handler changed, keep it
// otherwise, unregister $renderException