diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #30677 Fix type hints for email attachments (fabpot)

Browse Source 
This PR was merged into the 4.3-dev branch.

Discussion
----------

Fix type hints for email attachments

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

`createDataPart()` must return a `DataPart` instance, so `attachPart()` must only accept `DataPart` instances and `getAttachments()` is guaranteed to return an array of `DataPart` instances.

Commits
-------

8059c50e75 fixed type hints for email attachments
This commit is contained in:
Fabien Potencier 2019-03-25 09:54:47 +01:00
commit cb1ab077a7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Mime/Email.php
View File

@ -372,7 +372,7 @@ class Email extends Message
/**
* @return $this
*/
public function attachPart(AbstractPart $part)
public function attachPart(DataPart $part)
{
$this->attachments[] = ['part' => $part];
@ -380,7 +380,7 @@ class Email extends Message
}
/**
* @return AbstractPart[]
* @return DataPart[]
*/
public function getAttachments(): array
{