minor #24023 [VarDumper] Fix segfault in period caster (maidmaid)
This PR was merged into the 3.4 branch.
Discussion
----------
[VarDumper] Fix segfault in period caster
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/23668#issuecomment-325685087
| License | MIT
| Doc PR | /
[This segfault](https://bugs.php.net/bug.php?id=71635) was fixed in [5.6.20](http://www.php.net/ChangeLog-5.php#5.6.20) and in [7.0.5](http://www.php.net/ChangeLog-7.php#7.0.5).
Issue in action here: https://3v4l.org/DhOdT#v565
Commits
-------
d84e9c8
Fix segfault in period caster
This commit is contained in:
commit
cba3393f9d
@ -85,7 +85,7 @@ class DateCaster
|
||||
|
||||
public static function castPeriod(\DatePeriod $p, array $a, Stub $stub, $isNested, $filter)
|
||||
{
|
||||
if (defined('HHVM_VERSION_ID') || \PHP_VERSION_ID < 50605) {
|
||||
if (defined('HHVM_VERSION_ID') || \PHP_VERSION_ID < 50620 || (\PHP_VERSION_ID >= 70000 && \PHP_VERSION_ID < 70005)) { // see https://bugs.php.net/bug.php?id=71635
|
||||
return $a;
|
||||
}
|
||||
|
||||
|
@ -334,7 +334,7 @@ EODUMP;
|
||||
*/
|
||||
public function testCastPeriod($start, $interval, $end, $options, $xPeriod, $xDates)
|
||||
{
|
||||
if (defined('HHVM_VERSION_ID') || \PHP_VERSION_ID < 50605) {
|
||||
if (defined('HHVM_VERSION_ID') || \PHP_VERSION_ID < 50620 || (\PHP_VERSION_ID >= 70000 && \PHP_VERSION_ID < 70005)) {
|
||||
$this->markTestSkipped();
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user