From 3607eb3dd06bfaf11dcbd918bc8e9c89aa3b25f4 Mon Sep 17 00:00:00 2001 From: HeahDude Date: Tue, 10 Jan 2017 21:44:56 +0100 Subject: [PATCH] [Form] Removed unused ResolvedTypeFactory in FormFactory constructor --- src/Symfony/Component/Form/FormFactory.php | 11 +---------- src/Symfony/Component/Form/FormFactoryBuilder.php | 5 ++--- src/Symfony/Component/Form/Tests/FormFactoryTest.php | 12 +++--------- 3 files changed, 6 insertions(+), 22 deletions(-) diff --git a/src/Symfony/Component/Form/FormFactory.php b/src/Symfony/Component/Form/FormFactory.php index 169bc3f6b5..4360a62567 100644 --- a/src/Symfony/Component/Form/FormFactory.php +++ b/src/Symfony/Component/Form/FormFactory.php @@ -15,20 +15,11 @@ use Symfony\Component\Form\Exception\UnexpectedTypeException; class FormFactory implements FormFactoryInterface { - /** - * @var FormRegistryInterface - */ private $registry; - /** - * @var ResolvedFormTypeFactoryInterface - */ - private $resolvedTypeFactory; - - public function __construct(FormRegistryInterface $registry, ResolvedFormTypeFactoryInterface $resolvedTypeFactory) + public function __construct(FormRegistryInterface $registry) { $this->registry = $registry; - $this->resolvedTypeFactory = $resolvedTypeFactory; } /** diff --git a/src/Symfony/Component/Form/FormFactoryBuilder.php b/src/Symfony/Component/Form/FormFactoryBuilder.php index 64021eac7a..2f72e7a9a9 100644 --- a/src/Symfony/Component/Form/FormFactoryBuilder.php +++ b/src/Symfony/Component/Form/FormFactoryBuilder.php @@ -154,9 +154,8 @@ class FormFactoryBuilder implements FormFactoryBuilderInterface $extensions[] = new PreloadedExtension($this->types, $this->typeExtensions, $typeGuesser); } - $resolvedTypeFactory = $this->resolvedTypeFactory ?: new ResolvedFormTypeFactory(); - $registry = new FormRegistry($extensions, $resolvedTypeFactory); + $registry = new FormRegistry($extensions, $this->resolvedTypeFactory ?: new ResolvedFormTypeFactory()); - return new FormFactory($registry, $resolvedTypeFactory); + return new FormFactory($registry); } } diff --git a/src/Symfony/Component/Form/Tests/FormFactoryTest.php b/src/Symfony/Component/Form/Tests/FormFactoryTest.php index 27b5e20252..aadb18af27 100644 --- a/src/Symfony/Component/Form/Tests/FormFactoryTest.php +++ b/src/Symfony/Component/Form/Tests/FormFactoryTest.php @@ -37,11 +37,6 @@ class FormFactoryTest extends \PHPUnit_Framework_TestCase */ private $registry; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $resolvedTypeFactory; - /** * @var \PHPUnit_Framework_MockObject_MockObject */ @@ -54,12 +49,11 @@ class FormFactoryTest extends \PHPUnit_Framework_TestCase protected function setUp() { - $this->resolvedTypeFactory = $this->getMockBuilder('Symfony\Component\Form\ResolvedFormTypeFactoryInterface')->getMock(); $this->guesser1 = $this->getMockBuilder('Symfony\Component\Form\FormTypeGuesserInterface')->getMock(); $this->guesser2 = $this->getMockBuilder('Symfony\Component\Form\FormTypeGuesserInterface')->getMock(); $this->registry = $this->getMockBuilder('Symfony\Component\Form\FormRegistryInterface')->getMock(); $this->builder = $this->getMockBuilder('Symfony\Component\Form\Test\FormBuilderInterface')->getMock(); - $this->factory = new FormFactory($this->registry, $this->resolvedTypeFactory); + $this->factory = new FormFactory($this->registry); $this->registry->expects($this->any()) ->method('getTypeGuesser') @@ -244,7 +238,7 @@ class FormFactoryTest extends \PHPUnit_Framework_TestCase $registry = $this->getMockBuilder('Symfony\Component\Form\FormRegistryInterface')->getMock(); $factory = $this->getMockBuilder('Symfony\Component\Form\FormFactory') ->setMethods(array('createNamedBuilder')) - ->setConstructorArgs(array($registry, $this->resolvedTypeFactory)) + ->setConstructorArgs(array($registry)) ->getMock(); $factory->expects($this->once()) @@ -474,7 +468,7 @@ class FormFactoryTest extends \PHPUnit_Framework_TestCase { return $this->getMockBuilder('Symfony\Component\Form\FormFactory') ->setMethods($methods) - ->setConstructorArgs(array($this->registry, $this->resolvedTypeFactory)) + ->setConstructorArgs(array($this->registry)) ->getMock(); }