minor #32678 [Lock] remove all mention to StoreInterface in comments and tests (Simperfit)
This PR was merged into the 4.4 branch.
Discussion
----------
[Lock] remove all mention to StoreInterface in comments and tests
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | none <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | none <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
Update 4.4 with removing all mentions to StoreInterface in comments and tests whenever it's possible.
cc @nicolas-grekas
Commits
-------
699a88b2e7
[Lock] remove all mention to StoreInterface in comments and tests
This commit is contained in:
commit
cc25ab1a06
@ -23,7 +23,7 @@ use Symfony\Component\Lock\StoreInterface;
|
||||
use Symfony\Component\Lock\Strategy\StrategyInterface;
|
||||
|
||||
/**
|
||||
* CombinedStore is a StoreInterface implementation able to manage and synchronize several StoreInterfaces.
|
||||
* CombinedStore is a PersistingStoreInterface implementation able to manage and synchronize several StoreInterfaces.
|
||||
*
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
*/
|
||||
|
@ -19,7 +19,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* FlockStore is a StoreInterface implementation using the FileSystem flock.
|
||||
* FlockStore is a PersistingStoreInterface implementation using the FileSystem flock.
|
||||
*
|
||||
* Original implementation in \Symfony\Component\Filesystem\LockHandler.
|
||||
*
|
||||
|
@ -18,7 +18,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* MemcachedStore is a StoreInterface implementation using Memcached as store engine.
|
||||
* MemcachedStore is a PersistingStoreInterface implementation using Memcached as store engine.
|
||||
*
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
*/
|
||||
|
@ -22,7 +22,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* PdoStore is a StoreInterface implementation using a PDO connection.
|
||||
* PdoStore is a PersistingStoreInterface implementation using a PDO connection.
|
||||
*
|
||||
* Lock metadata are stored in a table. You can use createTable() to initialize
|
||||
* a correctly defined table.
|
||||
|
@ -20,7 +20,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* RedisStore is a StoreInterface implementation using Redis as store engine.
|
||||
* RedisStore is a PersistingStoreInterface implementation using Redis as store engine.
|
||||
*
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
*/
|
||||
|
@ -21,7 +21,7 @@ use Symfony\Component\Lock\PersistingStoreInterface;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* RetryTillSaveStore is a StoreInterface implementation which decorate a non blocking StoreInterface to provide a
|
||||
* RetryTillSaveStore is a PersistingStoreInterface implementation which decorate a non blocking PersistingStoreInterface to provide a
|
||||
* blocking storage.
|
||||
*
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
@ -35,7 +35,7 @@ class RetryTillSaveStore implements PersistingStoreInterface, BlockingStoreInter
|
||||
private $retryCount;
|
||||
|
||||
/**
|
||||
* @param PersistingStoreInterface $decorated The decorated StoreInterface
|
||||
* @param PersistingStoreInterface $decorated The decorated PersistingStoreInterface
|
||||
* @param int $retrySleep Duration in ms between 2 retry
|
||||
* @param int $retryCount Maximum amount of retry
|
||||
*/
|
||||
|
@ -18,7 +18,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* SemaphoreStore is a StoreInterface implementation using Semaphore as store engine.
|
||||
* SemaphoreStore is a PersistingStoreInterface implementation using Semaphore as store engine.
|
||||
*
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
*/
|
||||
|
@ -15,7 +15,7 @@ use Symfony\Component\Cache\Adapter\AbstractAdapter;
|
||||
use Symfony\Component\Cache\Traits\RedisClusterProxy;
|
||||
use Symfony\Component\Cache\Traits\RedisProxy;
|
||||
use Symfony\Component\Lock\Exception\InvalidArgumentException;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
use Symfony\Component\Lock\PersistingStoreInterface;
|
||||
|
||||
/**
|
||||
* StoreFactory create stores and connections.
|
||||
@ -27,7 +27,7 @@ class StoreFactory
|
||||
/**
|
||||
* @param \Redis|\RedisArray|\RedisCluster|\Predis\Client|\Memcached|\Zookeeper|string $connection Connection or DSN or Store short name
|
||||
*
|
||||
* @return StoreInterface
|
||||
* @return PersistingStoreInterface
|
||||
*/
|
||||
public static function createStore($connection)
|
||||
{
|
||||
|
@ -19,7 +19,7 @@ use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
|
||||
/**
|
||||
* ZookeeperStore is a StoreInterface implementation using Zookeeper as store engine.
|
||||
* ZookeeperStore is a PersistingStoreInterface implementation using Zookeeper as store engine.
|
||||
*
|
||||
* @author Ganesh Chandrasekaran <gchandrasekaran@wayfair.com>
|
||||
*/
|
||||
|
@ -13,7 +13,7 @@ namespace Symfony\Component\Lock\Tests\Store;
|
||||
|
||||
use Symfony\Component\Lock\Exception\LockExpiredException;
|
||||
use Symfony\Component\Lock\Key;
|
||||
use Symfony\Component\Lock\StoreInterface;
|
||||
use Symfony\Component\Lock\PersistingStoreInterface;
|
||||
|
||||
/**
|
||||
* @author Jérémy Derussé <jeremy@derusse.com>
|
||||
@ -44,7 +44,7 @@ trait ExpiringStoreTestTrait
|
||||
$key = new Key(uniqid(__METHOD__, true));
|
||||
$clockDelay = $this->getClockDelay();
|
||||
|
||||
/** @var StoreInterface $store */
|
||||
/** @var PersistingStoreInterface $store */
|
||||
$store = $this->getStore();
|
||||
|
||||
$store->save($key);
|
||||
@ -64,7 +64,7 @@ trait ExpiringStoreTestTrait
|
||||
{
|
||||
$key = new Key(uniqid(__METHOD__, true));
|
||||
|
||||
/** @var StoreInterface $store */
|
||||
/** @var PersistingStoreInterface $store */
|
||||
$store = $this->getStore();
|
||||
|
||||
$store->save($key);
|
||||
@ -83,7 +83,7 @@ trait ExpiringStoreTestTrait
|
||||
|
||||
$key = new Key(uniqid(__METHOD__, true));
|
||||
|
||||
/** @var StoreInterface $store */
|
||||
/** @var PersistingStoreInterface $store */
|
||||
$store = $this->getStore();
|
||||
|
||||
$store->save($key);
|
||||
@ -98,7 +98,7 @@ trait ExpiringStoreTestTrait
|
||||
{
|
||||
$key = new Key(uniqid(__METHOD__, true));
|
||||
|
||||
/** @var StoreInterface $store */
|
||||
/** @var PersistingStoreInterface $store */
|
||||
$store = $this->getStore();
|
||||
|
||||
$store->save($key);
|
||||
@ -114,7 +114,7 @@ trait ExpiringStoreTestTrait
|
||||
$key1 = new Key($resource);
|
||||
$key2 = new Key($resource);
|
||||
|
||||
/** @var StoreInterface $store */
|
||||
/** @var PersistingStoreInterface $store */
|
||||
$store = $this->getStore();
|
||||
$key1->reduceLifetime(0);
|
||||
|
||||
|
Reference in New Issue
Block a user