From 18f5b172495c4362c73cef43f7c39e51e8a4191f Mon Sep 17 00:00:00 2001 From: Wouter de Jong Date: Sun, 15 Mar 2020 13:01:42 +0100 Subject: [PATCH] [DI][Form] Fixed test suite (TimeType changes & unresolved merge conflict) --- .../Component/DependencyInjection/ContainerBuilder.php | 5 ----- src/Symfony/Component/Form/Extension/Core/Type/TimeType.php | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php index 68a751a20c..c210e03cef 100644 --- a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php +++ b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php @@ -994,13 +994,8 @@ class ContainerBuilder extends Container implements TaggedContainerInterface $id = (string) $id; -<<<<<<< HEAD if ('' === $id || '\\' === $id[-1] || \strlen($id) !== strcspn($id, "\0\r\n'")) { - throw new InvalidArgumentException(sprintf('Invalid service id: "%s"', $id)); -======= - if ('' === $id || '\\' === substr($id, -1) || \strlen($id) !== strcspn($id, "\0\r\n'")) { throw new InvalidArgumentException(sprintf('Invalid service id: "%s".', $id)); ->>>>>>> 3.4 } unset($this->aliasDefinitions[$id], $this->removedIds[$id]); diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php b/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php index 8dc0341353..092fa31d21 100644 --- a/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php +++ b/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php @@ -60,8 +60,6 @@ class TimeType extends AbstractType } if ('single_text' === $options['widget']) { - $builder->addViewTransformer(new DateTimeToStringTransformer($options['model_timezone'], $options['view_timezone'], $format)); - $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $e) use ($options) { $data = $e->getData(); if ($data && preg_match('/^(?P\d{2}):(?P\d{2})(?::(?P\d{2})(?:\.\d+)?)?$/', $data, $matches)) { @@ -86,6 +84,8 @@ class TimeType extends AbstractType } }); } + + $builder->addViewTransformer(new DateTimeToStringTransformer($options['model_timezone'], $options['view_timezone'], $format)); } else { $hourOptions = $minuteOptions = $secondOptions = [ 'error_bubbling' => true,