merged branch drak/flashcount (PR #6423)
This PR was merged into the 2.1 branch.
Commits
-------
8513777
[HttpFoundation] Update docblock for non-working method
Discussion
----------
[HttpFoundation] Update docblock for non-working method
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Rerences the following tickets: #6408
Todo: -
License of the code: MIT
Documentation PR: -
---------------------------------------------------------------------------
by piotrpasich at 2012-12-19T21:32:24Z
I think that we shouldn't comment it as not working but add new methods called countFlashes and countFlashesTypes. CountFlashesTypes should return count($this->flashBag) and countFlashes should count all items in every array inside flashbag.
---------------------------------------------------------------------------
by drak at 2012-12-20T17:43:38Z
ping @fabpot
This commit is contained in:
commit
cd04bd7a12
@ -177,6 +177,11 @@ class FlashBag implements FlashBagInterface, \IteratorAggregate, \Countable
|
||||
/**
|
||||
* Returns the number of flashes.
|
||||
*
|
||||
* This method does not work.
|
||||
*
|
||||
* @deprecated in 2.2, removed in 2.3
|
||||
* @see https://github.com/symfony/symfony/issues/6408
|
||||
*
|
||||
* @return int The number of flashes
|
||||
*/
|
||||
public function count()
|
||||
|
Reference in New Issue
Block a user