diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #23575 [VarDumper] Use "C" locale when using "comma" flags (nicolas-grekas)

Browse Source 
This PR was merged into the 3.3 branch.

Discussion
----------

[VarDumper] Use "C" locale when using "comma" flags

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23572
| License       | MIT
| Doc PR        | -

Adding trailing comma implicitly requires a C locale.

Commits
-------

305ae5e5d4 [VarDumper] Use "C" locale when using "comma" flags
This commit is contained in:
Fabien Potencier 2017-07-19 05:57:51 +02:00
commit cd2529432a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php
View File

@ -123,6 +123,10 @@ abstract class AbstractDumper implements DataDumperInterface, DumperInterface
*/
public function dump(Data $data, $output = null)
{
if ($locale = $this->flags & (self::DUMP_COMMA_SEPARATOR | self::DUMP_TRAILING_COMMA) ? setlocale(LC_NUMERIC, 0) : null) {
setlocale(LC_NUMERIC, 'C');
}
if ($returnDump = true === $output) {
$output = fopen('php://memory', 'r+b');
}
@ -143,6 +147,9 @@ abstract class AbstractDumper implements DataDumperInterface, DumperInterface
if ($output) {
$this->setOutput($prevOutput);
}
if ($locale) {
setlocale(LC_NUMERIC, $locale);
}
}
}