diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #11463 [Validator] prevent unnecessary calls inside ExecutionContext (Tobion) 

This PR was merged into the 2.5 branch.

Discussion
----------

[Validator] prevent unnecessary calls inside ExecutionContext

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT

Small performance improvement by preventing calls to `PropertyPath::append($this->propertyPath, $subPath)` when not needed.

Commits
-------

d6d462a [Validator] do not call getter inside ExecutionContext to prevent unnecessary calls
This commit is contained in:
Bernhard Schussek 2014-07-28 16:51:00 +02:00
parent 7e175ef8f3 d6d462a8a7
commit cd29962dc0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Component/Validator/Context/ExecutionContext.php
View File

@ -183,8 +183,8 @@ class ExecutionContext implements ExecutionContextInterface
$message,
$parameters,
$this->root,
$this->getPropertyPath(),
$this->getValue(),
$this->propertyPath,
$this->value,
null,
null
));
@ -200,8 +200,8 @@ class ExecutionContext implements ExecutionContextInterface
$message,
$parameters,
$this->root,
$this->getPropertyPath(),
$this->getValue(),
$this->propertyPath,
$this->value,
$this->translator,
$this->translationDomain
);