From cde223ad2af316ae8299ea0cec5f85c8363db1a8 Mon Sep 17 00:00:00 2001 From: david-binda Date: Fri, 16 Aug 2019 17:14:15 +0200 Subject: [PATCH] Remove unnecessary statement The casting of `$id` to string inside the second foreach loop in `\Symfony\Component\DependencyInjection\Dumper\PhpDumper::addMethodMap` is redundant, as the variable is not used after the casting inside nor outside the loop (while still in the loop, it gets overriden upon next iteration). Fixes #33206 --- src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php index e39f47acc8..64dfee8573 100644 --- a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php +++ b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php @@ -1170,7 +1170,6 @@ EOF; if (!$id->isDeprecated()) { continue; } - $id = (string) $id; $code .= ' '.$this->doExport($alias).' => '.$this->doExport($this->generateMethodName($alias)).",\n"; }