merged branch igorw/exception-listener-comment (PR #6611)
This PR was squashed before being merged into the 2.1 branch (closes #6611). Commits -------bde5a7f
[HttpKernel] Clarify misleading comment in ExceptionListener Discussion ---------- [HttpKernel] Clarify misleading comment in ExceptionListener Regression from295860dfaf
. --------------------------------------------------------------------------- by fabpot at 2013-01-08T09:02:53Z The comment is right. Returning without a Response will re-throw the exception (in HttpKernel). --------------------------------------------------------------------------- by staabm at 2013-01-08T11:00:36Z so the comment should point out, that the httpkernel will rethrow the exception in that case? --------------------------------------------------------------------------- by igorw at 2013-01-08T13:38:43Z I missed that on the commit I linked. I've updated the patch to re-introduce the comment but clarify that `throw` is in HttpKernel.
This commit is contained in:
commit
d0dc59c7b2
@ -89,7 +89,7 @@ class ExceptionListener implements EventSubscriberInterface
|
||||
// set handling to false otherwise it wont be able to handle further more
|
||||
$handling = false;
|
||||
|
||||
// re-throw the exception as this is a catch-all
|
||||
// re-throw the exception from within HttpKernel as this is a catch-all
|
||||
return;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user