From d1c34e87cb0292e30e4b3d36d6728510b777e843 Mon Sep 17 00:00:00 2001 From: Tobias Schultze Date: Wed, 13 Feb 2013 01:53:15 +0100 Subject: [PATCH] [Translator] coding style --- .../Component/Translation/MessageCatalogue.php | 3 +-- src/Symfony/Component/Translation/Translator.php | 12 ++++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/Symfony/Component/Translation/MessageCatalogue.php b/src/Symfony/Component/Translation/MessageCatalogue.php index e854732f71..a435a85827 100644 --- a/src/Symfony/Component/Translation/MessageCatalogue.php +++ b/src/Symfony/Component/Translation/MessageCatalogue.php @@ -24,8 +24,8 @@ class MessageCatalogue implements MessageCatalogueInterface, MetadataAwareInterf { private $messages = array(); private $metadata = array(); + private $resources = array(); private $locale; - private $resources; private $fallbackCatalogue; private $parent; @@ -41,7 +41,6 @@ class MessageCatalogue implements MessageCatalogueInterface, MetadataAwareInterf { $this->locale = $locale; $this->messages = $messages; - $this->resources = array(); } /** diff --git a/src/Symfony/Component/Translation/Translator.php b/src/Symfony/Component/Translation/Translator.php index 439a62d34b..2bec103dcf 100644 --- a/src/Symfony/Component/Translation/Translator.php +++ b/src/Symfony/Component/Translation/Translator.php @@ -56,15 +56,15 @@ class Translator implements TranslatorInterface /** * Constructor. * - * @param string $locale The locale - * @param MessageSelector $selector The message selector for pluralization + * @param string $locale The locale + * @param MessageSelector|null $selector The message selector for pluralization * * @api */ public function __construct($locale, MessageSelector $selector = null) { $this->locale = $locale; - $this->selector = null === $selector ? new MessageSelector() : $selector; + $this->selector = $selector ?: new MessageSelector(); } /** @@ -129,7 +129,7 @@ class Translator implements TranslatorInterface // needed as the fallback locales are linked to the already loaded catalogues $this->catalogues = array(); - $this->fallbackLocales = is_array($locales) ? $locales : array($locales); + $this->fallbackLocales = (array) $locales; } /** @@ -139,7 +139,7 @@ class Translator implements TranslatorInterface */ public function trans($id, array $parameters = array(), $domain = 'messages', $locale = null) { - if (!isset($locale)) { + if (null === $locale) { $locale = $this->getLocale(); } @@ -157,7 +157,7 @@ class Translator implements TranslatorInterface */ public function transChoice($id, $number, array $parameters = array(), $domain = 'messages', $locale = null) { - if (!isset($locale)) { + if (null === $locale) { $locale = $this->getLocale(); }