Merge branch '2.3' into 2.7
* 2.3: Refactoring EntityUserProvider::__construct() to not do work, cause cache warm error
This commit is contained in:
commit
d1d9ab7d2a
@ -27,22 +27,17 @@ use Symfony\Component\Security\Core\User\UserInterface;
|
|||||||
*/
|
*/
|
||||||
class EntityUserProvider implements UserProviderInterface
|
class EntityUserProvider implements UserProviderInterface
|
||||||
{
|
{
|
||||||
|
private $registry;
|
||||||
|
private $managerName;
|
||||||
|
private $classOrAlias;
|
||||||
private $class;
|
private $class;
|
||||||
private $repository;
|
|
||||||
private $property;
|
private $property;
|
||||||
private $metadata;
|
|
||||||
|
|
||||||
public function __construct(ManagerRegistry $registry, $class, $property = null, $managerName = null)
|
public function __construct(ManagerRegistry $registry, $classOrAlias, $property = null, $managerName = null)
|
||||||
{
|
{
|
||||||
$em = $registry->getManager($managerName);
|
$this->registry = $registry;
|
||||||
$this->class = $class;
|
$this->managerName = $managerName;
|
||||||
$this->metadata = $em->getClassMetadata($class);
|
$this->classOrAlias = $classOrAlias;
|
||||||
|
|
||||||
if (false !== strpos($this->class, ':')) {
|
|
||||||
$this->class = $this->metadata->getName();
|
|
||||||
}
|
|
||||||
|
|
||||||
$this->repository = $em->getRepository($class);
|
|
||||||
$this->property = $property;
|
$this->property = $property;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -51,14 +46,15 @@ class EntityUserProvider implements UserProviderInterface
|
|||||||
*/
|
*/
|
||||||
public function loadUserByUsername($username)
|
public function loadUserByUsername($username)
|
||||||
{
|
{
|
||||||
|
$repository = $this->getRepository();
|
||||||
if (null !== $this->property) {
|
if (null !== $this->property) {
|
||||||
$user = $this->repository->findOneBy(array($this->property => $username));
|
$user = $repository->findOneBy(array($this->property => $username));
|
||||||
} else {
|
} else {
|
||||||
if (!$this->repository instanceof UserProviderInterface) {
|
if (!$repository instanceof UserProviderInterface) {
|
||||||
throw new \InvalidArgumentException(sprintf('The Doctrine repository "%s" must implement UserProviderInterface.', get_class($this->repository)));
|
throw new \InvalidArgumentException(sprintf('The Doctrine repository "%s" must implement UserProviderInterface.', get_class($repository)));
|
||||||
}
|
}
|
||||||
|
|
||||||
$user = $this->repository->loadUserByUsername($username);
|
$user = $repository->loadUserByUsername($username);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (null === $user) {
|
if (null === $user) {
|
||||||
@ -73,18 +69,20 @@ class EntityUserProvider implements UserProviderInterface
|
|||||||
*/
|
*/
|
||||||
public function refreshUser(UserInterface $user)
|
public function refreshUser(UserInterface $user)
|
||||||
{
|
{
|
||||||
if (!$user instanceof $this->class) {
|
$class = $this->getClass();
|
||||||
|
if (!$user instanceof $class) {
|
||||||
throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_class($user)));
|
throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_class($user)));
|
||||||
}
|
}
|
||||||
|
|
||||||
if ($this->repository instanceof UserProviderInterface) {
|
$repository = $this->getRepository();
|
||||||
$refreshedUser = $this->repository->refreshUser($user);
|
if ($repository instanceof UserProviderInterface) {
|
||||||
|
$refreshedUser = $repository->refreshUser($user);
|
||||||
} else {
|
} else {
|
||||||
// The user must be reloaded via the primary key as all other data
|
// The user must be reloaded via the primary key as all other data
|
||||||
// might have changed without proper persistence in the database.
|
// might have changed without proper persistence in the database.
|
||||||
// That's the case when the user has been changed by a form with
|
// That's the case when the user has been changed by a form with
|
||||||
// validation errors.
|
// validation errors.
|
||||||
if (!$id = $this->metadata->getIdentifierValues($user)) {
|
if (!$id = $this->getClassMetadata()->getIdentifierValues($user)) {
|
||||||
throw new \InvalidArgumentException('You cannot refresh a user '.
|
throw new \InvalidArgumentException('You cannot refresh a user '.
|
||||||
'from the EntityUserProvider that does not contain an identifier. '.
|
'from the EntityUserProvider that does not contain an identifier. '.
|
||||||
'The user object has to be serialized with its own identifier '.
|
'The user object has to be serialized with its own identifier '.
|
||||||
@ -92,7 +90,7 @@ class EntityUserProvider implements UserProviderInterface
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
$refreshedUser = $this->repository->find($id);
|
$refreshedUser = $repository->find($id);
|
||||||
if (null === $refreshedUser) {
|
if (null === $refreshedUser) {
|
||||||
throw new UsernameNotFoundException(sprintf('User with id %s not found', json_encode($id)));
|
throw new UsernameNotFoundException(sprintf('User with id %s not found', json_encode($id)));
|
||||||
}
|
}
|
||||||
@ -106,6 +104,36 @@ class EntityUserProvider implements UserProviderInterface
|
|||||||
*/
|
*/
|
||||||
public function supportsClass($class)
|
public function supportsClass($class)
|
||||||
{
|
{
|
||||||
return $class === $this->class || is_subclass_of($class, $this->class);
|
return $class === $this->getClass() || is_subclass_of($class, $this->getClass());
|
||||||
|
}
|
||||||
|
|
||||||
|
private function getObjectManager()
|
||||||
|
{
|
||||||
|
return $this->registry->getManager($this->managerName);
|
||||||
|
}
|
||||||
|
|
||||||
|
private function getRepository()
|
||||||
|
{
|
||||||
|
return $this->getObjectManager()->getRepository($this->classOrAlias);
|
||||||
|
}
|
||||||
|
|
||||||
|
private function getClass()
|
||||||
|
{
|
||||||
|
if (null === $this->class) {
|
||||||
|
$class = $this->classOrAlias;
|
||||||
|
|
||||||
|
if (false !== strpos($class, ':')) {
|
||||||
|
$class = $this->getClassMetadata()->getName();
|
||||||
|
}
|
||||||
|
|
||||||
|
$this->class = $class;
|
||||||
|
}
|
||||||
|
|
||||||
|
return $this->class;
|
||||||
|
}
|
||||||
|
|
||||||
|
private function getClassMetadata()
|
||||||
|
{
|
||||||
|
return $this->getObjectManager()->getClassMetadata($this->classOrAlias);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -92,7 +92,7 @@ class EntityUserProviderTest extends \PHPUnit_Framework_TestCase
|
|||||||
private function getManager($em, $name = null)
|
private function getManager($em, $name = null)
|
||||||
{
|
{
|
||||||
$manager = $this->getMock('Doctrine\Common\Persistence\ManagerRegistry');
|
$manager = $this->getMock('Doctrine\Common\Persistence\ManagerRegistry');
|
||||||
$manager->expects($this->once())
|
$manager->expects($this->any())
|
||||||
->method('getManager')
|
->method('getManager')
|
||||||
->with($this->equalTo($name))
|
->with($this->equalTo($name))
|
||||||
->will($this->returnValue($em));
|
->will($this->returnValue($em));
|
||||||
|
Reference in New Issue
Block a user