diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[HttpFoundation] Fix Cookie::isCleared

Browse Source
This commit is contained in:
Roland Franssen 2018-07-23 20:55:22 +02:00
parent a57549d0a1
commit d3d7766874
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/HttpFoundation/Cookie.php
View File

@ -183,6 +183,6 @@ class Cookie
*/ */
public function isCleared() public function isCleared()
{ {
return $this->expire < time(); return 0 !== $this->expire && $this->expire < time();
} }
} }

12
src/Symfony/Component/HttpFoundation/Tests/CookieTest.php
View File

@ -153,6 +153,18 @@ class CookieTest extends TestCase
$cookie = new Cookie('foo', 'bar', time() - 20); $cookie = new Cookie('foo', 'bar', time() - 20);
$this->assertTrue($cookie->isCleared(), '->isCleared() returns true if the cookie has expired'); $this->assertTrue($cookie->isCleared(), '->isCleared() returns true if the cookie has expired');
$cookie = new Cookie('foo', 'bar');
$this->assertFalse($cookie->isCleared());
$cookie = new Cookie('foo', 'bar', 0);
$this->assertFalse($cookie->isCleared());
$cookie = new Cookie('foo', 'bar', -1);
$this->assertFalse($cookie->isCleared());
} }
public function testToString() public function testToString()