minor #17108 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM (nicolas-grekas)
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
phpunit reports:
- before: `Memory: 430.91Mb`
- after: `Memory: 21.26Mb`
Commits
-------
cb23212
[Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
This commit is contained in:
commit
d481dda329
@ -85,6 +85,10 @@ class PhpGeneratorDumperTest extends \PHPUnit_Framework_TestCase
|
|||||||
|
|
||||||
public function testDumpWithTooManyRoutes()
|
public function testDumpWithTooManyRoutes()
|
||||||
{
|
{
|
||||||
|
if (defined('HHVM_VERSION_ID')) {
|
||||||
|
$this->markTestSkipped('HHVM consumes too much memory on this test.');
|
||||||
|
}
|
||||||
|
|
||||||
$this->routeCollection->add('Test', new Route('/testing/{foo}'));
|
$this->routeCollection->add('Test', new Route('/testing/{foo}'));
|
||||||
for ($i = 0; $i < 32769; ++$i) {
|
for ($i = 0; $i < 32769; ++$i) {
|
||||||
$this->routeCollection->add('route_'.$i, new Route('/route_'.$i));
|
$this->routeCollection->add('route_'.$i, new Route('/route_'.$i));
|
||||||
|
Reference in New Issue
Block a user