diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #40955 [Notifier] [Bridge] Fix missed messageId for SendMessage object in slack notifier (WaylandAce)

Browse Source 
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] [Bridge] Fix missed messageId for SendMessage object in slack notifier

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | -
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

There are missed messageId property for SendMessage object in slack notifier.
Regarding slack's documentation: https://api.slack.com/messaging/sending#publishing

> One very important piece of information in this response is the `ts` value, which is essentially the ID of the message,

Commits
-------

838f36b09f [Notifier] [Bridge] Store message id for slack transport's SendMessage
This commit is contained in:
Nicolas Grekas 2021-05-07 16:06:30 +02:00
commit d76bfb5a62
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Notifier/Bridge/Slack/SlackTransport.php
View File

@ -91,6 +91,9 @@ final class SlackTransport extends AbstractTransport
throw new TransportException(sprintf('Unable to post the Slack message: "%s".', $result['error']), $response);
}
return new SentMessage($message, (string) $this);
$sentMessage = new SentMessage($message, (string) $this);
$sentMessage->setMessageId($result['ts']);
return $sentMessage;
}
}

12
src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportTest.php
View File

@ -110,7 +110,7 @@ final class SlackTransportTest extends TransportTestCase
$response->expects($this->once())
->method('getContent')
->willReturn(json_encode(['ok' => true]));
->willReturn(json_encode(['ok' => true, 'ts' => '1503435956.000247']));
$expectedBody = json_encode(['channel' => $channel, 'text' => $message]);
@ -122,7 +122,9 @@ final class SlackTransportTest extends TransportTestCase
$transport = $this->createTransport($client, $channel);
$transport->send(new ChatMessage('testMessage'));
$sentMessage = $transport->send(new ChatMessage('testMessage'));
$this->assertSame('1503435956.000247', $sentMessage->getMessageId());
}
public function testSendWithNotification()
@ -138,7 +140,7 @@ final class SlackTransportTest extends TransportTestCase
$response->expects($this->once())
->method('getContent')
->willReturn(json_encode(['ok' => true]));
->willReturn(json_encode(['ok' => true, 'ts' => '1503435956.000247']));
$notification = new Notification($message);
$chatMessage = ChatMessage::fromNotification($notification);
@ -158,7 +160,9 @@ final class SlackTransportTest extends TransportTestCase
$transport = $this->createTransport($client, $channel);
$transport->send($chatMessage);
$sentMessage = $transport->send($chatMessage);
$this->assertSame('1503435956.000247', $sentMessage->getMessageId());
}
public function testSendWithInvalidOptions()