[Profiler] Still show locale and fallback locale even if no trans used

This commit is contained in:
Maxime Steinhausser 2019-01-04 18:02:37 +01:00 committed by Fabien Potencier
parent 44aa362419
commit d80bfad54e

View File

@ -56,38 +56,9 @@
{% endblock %} {% endblock %}
{% block panel %} {% block panel %}
{% if collector.messages is empty %}
<h2>Translations</h2>
<div class="empty">
<p>No translations have been called.</p>
</div>
{% else %}
{{ block('panelContent') }}
{% endif %}
{% endblock %}
{% block panelContent %}
<h2>Translation</h2> <h2>Translation</h2>
<div class="metrics"> <div class="metrics">
<div class="metric">
<span class="value">{{ collector.countDefines }}</span>
<span class="label">Defined messages</span>
</div>
<div class="metric">
<span class="value">{{ collector.countFallbacks }}</span>
<span class="label">Fallback messages</span>
</div>
<div class="metric">
<span class="value">{{ collector.countMissings }}</span>
<span class="label">Missing messages</span>
</div>
<div class="metric-divider"></div>
<div class="metric"> <div class="metric">
<span class="value">{{ collector.locale|default('-') }}</span> <span class="value">{{ collector.locale|default('-') }}</span>
<span class="label">Locale</span> <span class="label">Locale</span>
@ -100,88 +71,94 @@
<h2>Messages</h2> <h2>Messages</h2>
{% block messages %} {% if collector.messages is empty %}
<div class="empty">
<p>No translations have been called.</p>
</div>
{% else %}
{% block messages %}
{# sort translation messages in groups #} {# sort translation messages in groups #}
{% set messages_defined, messages_missing, messages_fallback = [], [], [] %} {% set messages_defined, messages_missing, messages_fallback = [], [], [] %}
{% for message in collector.messages %} {% for message in collector.messages %}
{% if message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_DEFINED') %} {% if message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_DEFINED') %}
{% set messages_defined = messages_defined|merge([message]) %} {% set messages_defined = messages_defined|merge([message]) %}
{% elseif message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_MISSING') %} {% elseif message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_MISSING') %}
{% set messages_missing = messages_missing|merge([message]) %} {% set messages_missing = messages_missing|merge([message]) %}
{% elseif message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_EQUALS_FALLBACK') %} {% elseif message.state == constant('Symfony\\Component\\Translation\\DataCollectorTranslator::MESSAGE_EQUALS_FALLBACK') %}
{% set messages_fallback = messages_fallback|merge([message]) %} {% set messages_fallback = messages_fallback|merge([message]) %}
{% endif %} {% endif %}
{% endfor %} {% endfor %}
<div class="sf-tabs"> <div class="sf-tabs">
<div class="tab {{ collector.countMissings == 0 ? 'active' }}"> <div class="tab {{ collector.countMissings == 0 ? 'active' }}">
<h3 class="tab-title">Defined <span class="badge">{{ collector.countDefines }}</span></h3> <h3 class="tab-title">Defined <span class="badge">{{ collector.countDefines }}</span></h3>
<div class="tab-content"> <div class="tab-content">
<p class="help"> <p class="help">
These messages are correctly translated into the given locale. These messages are correctly translated into the given locale.
</p> </p>
{% if messages_defined is empty %} {% if messages_defined is empty %}
<div class="empty"> <div class="empty">
<p>None of the used translation messages are defined for the given locale.</p> <p>None of the used translation messages are defined for the given locale.</p>
</div> </div>
{% else %} {% else %}
{% block defined_messages %} {% block defined_messages %}
{{ helper.render_table(messages_defined) }} {{ helper.render_table(messages_defined) }}
{% endblock %} {% endblock %}
{% endif %} {% endif %}
</div>
</div>
<div class="tab">
<h3 class="tab-title">Fallback <span class="badge {{ collector.countFallbacks ? 'status-warning' }}">{{ collector.countFallbacks }}</span></h3>
<div class="tab-content">
<p class="help">
These messages are not available for the given locale
but Symfony found them in the fallback locale catalog.
</p>
{% if messages_fallback is empty %}
<div class="empty">
<p>No fallback translation messages were used.</p>
</div>
{% else %}
{% block fallback_messages %}
{{ helper.render_table(messages_fallback) }}
{% endblock %}
{% endif %}
</div>
</div>
<div class="tab {{ collector.countMissings > 0 ? 'active' }}">
<h3 class="tab-title">Missing <span class="badge {{ collector.countMissings ? 'status-error' }}">{{ collector.countMissings }}</span></h3>
<div class="tab-content">
<p class="help">
These messages are not available for the given locale and cannot
be found in the fallback locales. Add them to the translation
catalogue to avoid Symfony outputting untranslated contents.
</p>
{% if messages_missing is empty %}
<div class="empty">
<p>There are no messages of this category.</p>
</div>
{% else %}
{% block missing_messages %}
{{ helper.render_table(messages_missing) }}
{% endblock %}
{% endif %}
</div>
</div> </div>
</div> </div>
<div class="tab"> <script>Sfjs.createFilters();</script>
<h3 class="tab-title">Fallback <span class="badge {{ collector.countFallbacks ? 'status-warning' }}">{{ collector.countFallbacks }}</span></h3>
<div class="tab-content"> {% endblock messages %}
<p class="help"> {% endif %}
These messages are not available for the given locale
but Symfony found them in the fallback locale catalog.
</p>
{% if messages_fallback is empty %}
<div class="empty">
<p>No fallback translation messages were used.</p>
</div>
{% else %}
{% block fallback_messages %}
{{ helper.render_table(messages_fallback) }}
{% endblock %}
{% endif %}
</div>
</div>
<div class="tab {{ collector.countMissings > 0 ? 'active' }}">
<h3 class="tab-title">Missing <span class="badge {{ collector.countMissings ? 'status-error' }}">{{ collector.countMissings }}</span></h3>
<div class="tab-content">
<p class="help">
These messages are not available for the given locale and cannot
be found in the fallback locales. Add them to the translation
catalogue to avoid Symfony outputting untranslated contents.
</p>
{% if messages_missing is empty %}
<div class="empty">
<p>There are no messages of this category.</p>
</div>
{% else %}
{% block missing_messages %}
{{ helper.render_table(messages_missing) }}
{% endblock %}
{% endif %}
</div>
</div>
</div>
<script>Sfjs.createFilters();</script>
{% endblock messages %}
{% endblock %} {% endblock %}